[PR #15378] feat: Refactor fetch() usage #10602

New Issue

GiteaMirror · 2025-11-11T19:08:58-06:00

GiteaMirror commented

2025-11-11 19:08:58 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15378
Author: @jeffposnick
Created: 6/28/2025
Status: 🔄 Open

Base: dev ← Head: fetch-impl

📝 Commits (1)

3d3b824 feat: Refactor fetch() usage

📊 Changes

28 files changed (+330 additions, -300 deletions)

View changed files

📝 src/lib/apis/audio/index.ts (+7 -6)
📝 src/lib/apis/auths/index.ts (+25 -24)
📝 src/lib/apis/channels/index.ts (+13 -12)
📝 src/lib/apis/chats/index.ts (+32 -31)
📝 src/lib/apis/configs/index.ts (+15 -14)
📝 src/lib/apis/evaluations/index.ts (+9 -8)
📝 src/lib/apis/files/index.ts (+9 -8)
📝 src/lib/apis/folders/index.ts (+9 -8)
📝 src/lib/apis/functions/index.ts (+16 -15)
📝 src/lib/apis/groups/index.ts (+6 -5)
📝 src/lib/apis/images/index.ts (+8 -7)
📝 src/lib/apis/index.ts (+37 -36)
📝 src/lib/apis/knowledge/index.ts (+12 -11)
📝 src/lib/apis/memories/index.ts (+7 -6)
📝 src/lib/apis/models/index.ts (+9 -8)
📝 src/lib/apis/notes/index.ts (+6 -5)
📝 src/lib/apis/ollama/index.ts (+19 -18)
📝 src/lib/apis/openai/index.ts (+14 -13)
📝 src/lib/apis/prompts/index.ts (+7 -6)
📝 src/lib/apis/retrieval/index.ts (+17 -16)

...and 8 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Custom installations of Open WebUI may need to override the default fetch() behavior used in the web app, to, for example, ensure that specific request headers are always sent, or ensure that fresh authorization credentials are present. Currently, these fetch() calls are made throughout many individual files in the codebase, and each of those fetch() calls would have to be modified in order to achieve the desired behavior. This PR refactors things so that a central exported fetchImpl is used throughout the codebase, allowing that fetchImpl to be overridden in one place if needed. By default, fetchImpl is set to fetch, so there shouldn't be any change in behavior unless someone takes steps to customize things locally.

Added

n/a

Changed

Calls to fetch() throughout the TypeScript codebase have been replaced with calls to a fetchImpl() function, which is exported from ./src/lib/fetch.ts. The export defines fetchImpl as fetch by default, so there should be no functional change, but this approach will make it simpler to customize the fetch() calls made by Open WebUI in a custom installation.

Deprecated

n/a

Removed

n/a

Fixed

n/a

Security

n/a

Breaking Changes

n/a

Additional Information

https://github.com/open-webui/open-webui/discussions/14352

Screenshots or Videos

n/a

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15378 **Author:** [@jeffposnick](https://github.com/jeffposnick) **Created:** 6/28/2025 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fetch-impl` --- ### 📝 Commits (1) - [`3d3b824`](https://github.com/open-webui/open-webui/commit/3d3b8247333685f55290c7fa3fa885c805733bff) feat: Refactor fetch() usage ### 📊 Changes **28 files changed** (+330 additions, -300 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/apis/audio/index.ts` (+7 -6) 📝 `src/lib/apis/auths/index.ts` (+25 -24) 📝 `src/lib/apis/channels/index.ts` (+13 -12) 📝 `src/lib/apis/chats/index.ts` (+32 -31) 📝 `src/lib/apis/configs/index.ts` (+15 -14) 📝 `src/lib/apis/evaluations/index.ts` (+9 -8) 📝 `src/lib/apis/files/index.ts` (+9 -8) 📝 `src/lib/apis/folders/index.ts` (+9 -8) 📝 `src/lib/apis/functions/index.ts` (+16 -15) 📝 `src/lib/apis/groups/index.ts` (+6 -5) 📝 `src/lib/apis/images/index.ts` (+8 -7) 📝 `src/lib/apis/index.ts` (+37 -36) 📝 `src/lib/apis/knowledge/index.ts` (+12 -11) 📝 `src/lib/apis/memories/index.ts` (+7 -6) 📝 `src/lib/apis/models/index.ts` (+9 -8) 📝 `src/lib/apis/notes/index.ts` (+6 -5) 📝 `src/lib/apis/ollama/index.ts` (+19 -18) 📝 `src/lib/apis/openai/index.ts` (+14 -13) 📝 `src/lib/apis/prompts/index.ts` (+7 -6) 📝 `src/lib/apis/retrieval/index.ts` (+17 -16) _...and 8 more files_ </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Custom installations of Open WebUI may need to override the default `fetch()` behavior used in the web app, to, for example, ensure that specific request headers are always sent, or ensure that fresh authorization credentials are present. Currently, these `fetch()` calls are made throughout many individual files in the codebase, and each of those `fetch()` calls would have to be modified in order to achieve the desired behavior. This PR refactors things so that a central exported `fetchImpl` is used throughout the codebase, allowing that `fetchImpl` to be overridden in one place if needed. By default, `fetchImpl` is set to `fetch`, so there shouldn't be any change in behavior unless someone takes steps to customize things locally. ### Added - n/a ### Changed - Calls to `fetch()` throughout the TypeScript codebase have been replaced with calls to a `fetchImpl()` function, which is exported from `./src/lib/fetch.ts`. The export defines `fetchImpl` as `fetch` by default, so there should be no functional change, but this approach will make it simpler to customize the `fetch()` calls made by Open WebUI in a custom installation. ### Deprecated - n/a ### Removed - n/a ### Fixed - n/a ### Security - n/a ### Breaking Changes - n/a --- ### Additional Information - https://github.com/open-webui/open-webui/discussions/14352 ### Screenshots or Videos - n/a ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:08:58 -06:00

GiteaMirror referenced this issue

2026-04-19 22:00:59 -05:00

[GH-ISSUE #10602] When generating images, the thinking process is also sent to ComfyUI #15952

GiteaMirror referenced this issue

2026-04-25 05:24:45 -05:00

[GH-ISSUE #10602] When generating images, the thinking process is also sent to ComfyUI #31481

GiteaMirror referenced this issue

2026-05-05 16:28:45 -05:00

[GH-ISSUE #10602] When generating images, the thinking process is also sent to ComfyUI #54618

GiteaMirror referenced this issue

2026-05-13 02:38:07 -05:00