[PR #14992] [MERGED] Fix: Added support for multiple pages in external document loader #10471

New Issue

GiteaMirror · 2025-11-11T19:05:50-06:00

GiteaMirror commented

2025-11-11 19:05:50 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14992
Author: @sreesdas
Created: 6/15/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @tjbck

Base: dev ← Head: dev

📝 Commits (1)

62bfe73 Fix: Added support for multiple pages in external document loader, added filename in api request header

📊 Changes

1 file changed (+35 additions, -14 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/external_document.py (+35 -14)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The external document loader now supports multiple pages when the custom API server returns a json array with contents of each page separately.
This way, the external loader can implement custom splitting and chunking strategies
The file name metadata is added to the API request header as X-Filename

Changed

The api response is handled based on whether the response is a dict or an array
Option to set custom metadata for each page separately

Breaking Changes

No breaking changes as the code is backward compatible with the older login

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14992 **Author:** [@sreesdas](https://github.com/sreesdas) **Created:** 6/15/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`62bfe73`](https://github.com/open-webui/open-webui/commit/62bfe7396497dbd670e9613b36d4445cbcb1860f) Fix: Added support for multiple pages in external document loader, added filename in api request header ### 📊 Changes **1 file changed** (+35 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/external_document.py` (+35 -14) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - The external document loader now supports multiple pages when the custom API server returns a json array with contents of each page separately. - This way, the external loader can implement custom splitting and chunking strategies - The file name metadata is added to the API request header as X-Filename ### Changed - The api response is handled based on whether the response is a dict or an array - Option to set custom metadata for each page separately ### Breaking Changes - No breaking changes as the code is backward compatible with the older login --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:05:50 -06:00

GiteaMirror closed this issue

2025-11-11 19:05:50 -06:00

GiteaMirror referenced this issue

2026-04-19 21:59:06 -05:00

[GH-ISSUE #10471] Advanced Parameters Not Saving #15902

GiteaMirror referenced this issue

2026-04-25 05:23:08 -05:00

[GH-ISSUE #10471] Advanced Parameters Not Saving #31431

GiteaMirror referenced this issue

2026-05-05 16:25:31 -05:00

[GH-ISSUE #10471] Advanced Parameters Not Saving #54568