Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Page number inside citation is displayed using {document.metadata.page + 1}. But its container have a condition {#if Number.isInteger(document?.metadata?.page)}. When the document?.metadata?.page == 0 (page 1), the page number will not be displayed. This change aims to fix the issue.
Changed
Modified src/lib/components/chat/Messages/CitationsModal.svelte to use {#if Number.isInteger(document?.metadata?.page)} to check if the page number exist
Fixed
Fixed the issue that page number 1 will not display on citation reference
Screenshots or Videos
Before:
After:
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/14946
**Author:** [@t-rekttt](https://github.com/t-rekttt)
**Created:** 6/12/2025
**Status:** ✅ Merged
**Merged:** 6/13/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `patch-1`
---
### 📝 Commits (1)
- [`190400d`](https://github.com/open-webui/open-webui/commit/190400d1e85237da97e638c5898ca3579efe46ea) Fix: page number edge case
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `src/lib/components/chat/Messages/CitationsModal.svelte` (+1 -1)
</details>
### 📄 Description
# Pull Request Checklist
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests to validate the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- Page number inside citation is displayed using `{document.metadata.page + 1}`. But its container have a condition `{#if Number.isInteger(document?.metadata?.page)}`. When the `document?.metadata?.page == 0` (page 1), the page number will not be displayed. This change aims to fix the issue.
### Changed
- Modified `src/lib/components/chat/Messages/CitationsModal.svelte` to use `{#if Number.isInteger(document?.metadata?.page)}` to check if the page number exist
### Fixed
- Fixed the issue that page number 1 will not display on citation reference
### Screenshots or Videos
Before:
After:
### Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/14946
Author: @t-rekttt
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/13/2025
Merged by: @tjbck
Base:
dev← Head:patch-1📝 Commits (1)
190400dFix: page number edge case📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
src/lib/components/chat/Messages/CitationsModal.svelte(+1 -1)📄 Description
Pull Request Checklist
devbranch.Changelog Entry
Description
{document.metadata.page + 1}. But its container have a condition{#if Number.isInteger(document?.metadata?.page)}. When thedocument?.metadata?.page == 0(page 1), the page number will not be displayed. This change aims to fix the issue.Changed
src/lib/components/chat/Messages/CitationsModal.svelteto use{#if Number.isInteger(document?.metadata?.page)}to check if the page number existFixed
Screenshots or Videos
Before:
After:
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.