github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-03-13 02:24:42 -05:00
Code Issues 308 Packages Projects Releases 100 Wiki Activity

[PR #14930] [CLOSED] Feat: password button accessibility #10445

New Issue
Closed
opened 2025-11-11 19:04:57 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 19:04:57 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14930
Author: @sinejespersen
Created: 6/12/2025
Status: ❌ Closed

Base: dev ← Head: feature/password-button-accessibility

📝 Commits (6)

  • 001fab1 Add aria label to toggle visibility button
  • d1968c2 add aria-hidden to decorative svgs
  • 506020d add aria pressed to toggle visibility button, to show current state to assistive technology
  • aec250c add label to password input
  • 66a73b6 make outline hidden depend on highContrastMode
  • 4038bff npm run i18n:parse

📊 Changes

55 files changed (+171 additions, -57 deletions)

View changed files

📝 src/lib/components/chat/Settings/Connections/Connection.svelte (+4 -2)
📝 src/lib/components/common/SensitiveInput.svelte (+10 -2)
📝 src/lib/i18n/locales/ar-BH/translation.json (+3 -1)
📝 src/lib/i18n/locales/ar/translation.json (+3 -1)
📝 src/lib/i18n/locales/bg-BG/translation.json (+3 -1)
📝 src/lib/i18n/locales/bn-BD/translation.json (+3 -1)
📝 src/lib/i18n/locales/bo-TB/translation.json (+3 -1)
📝 src/lib/i18n/locales/ca-ES/translation.json (+3 -1)
📝 src/lib/i18n/locales/ceb-PH/translation.json (+3 -1)
📝 src/lib/i18n/locales/cs-CZ/translation.json (+3 -1)
📝 src/lib/i18n/locales/da-DK/translation.json (+3 -1)
📝 src/lib/i18n/locales/de-DE/translation.json (+3 -1)
📝 src/lib/i18n/locales/dg-DG/translation.json (+3 -1)
📝 src/lib/i18n/locales/el-GR/translation.json (+3 -1)
📝 src/lib/i18n/locales/en-GB/translation.json (+3 -1)
📝 src/lib/i18n/locales/en-US/translation.json (+3 -1)
📝 src/lib/i18n/locales/es-ES/translation.json (+3 -1)
📝 src/lib/i18n/locales/et-EE/translation.json (+3 -1)
📝 src/lib/i18n/locales/eu-ES/translation.json (+3 -1)
📝 src/lib/i18n/locales/fa-IR/translation.json (+3 -1)

...and 35 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Hide decorative svgs from screen readers
  • Add high contrast mode on sensitive input
  • Add aria-pressed to toggle button
  • Add <label to password input (Only visible to screen readers .sr-only)
  • Aria label to button that only has an svg inside

Added

N/A

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

Screenshot 2025-06-12 at 13 32 07 Screenshot 2025-06-12 at 13 32 11 Screenshot 2025-06-12 at 14 05 33

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14930 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 6/12/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feature/password-button-accessibility` --- ### 📝 Commits (6) - [`001fab1`](https://github.com/open-webui/open-webui/commit/001fab117fa578e9018e69ccde4d888074d56680) Add aria label to toggle visibility button - [`d1968c2`](https://github.com/open-webui/open-webui/commit/d1968c21d4164b06288979b9c3d2ec1f4789af2d) add aria-hidden to decorative svgs - [`506020d`](https://github.com/open-webui/open-webui/commit/506020dd376ab2adeea843f32bdb5551aab49279) add aria pressed to toggle visibility button, to show current state to assistive technology - [`aec250c`](https://github.com/open-webui/open-webui/commit/aec250c6e4fdc508e90d2de692719de5c8a543ad) add label to password input - [`66a73b6`](https://github.com/open-webui/open-webui/commit/66a73b664314d4e4c16366cc42cfd30385061f9f) make outline hidden depend on highContrastMode - [`4038bff`](https://github.com/open-webui/open-webui/commit/4038bffbc17e3b30b5a5aad84991aeebf4462647) npm run i18n:parse ### 📊 Changes **55 files changed** (+171 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Connections/Connection.svelte` (+4 -2) 📝 `src/lib/components/common/SensitiveInput.svelte` (+10 -2) 📝 `src/lib/i18n/locales/ar-BH/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/ar/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/bg-BG/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/bn-BD/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/bo-TB/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/ca-ES/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/ceb-PH/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/cs-CZ/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/da-DK/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/de-DE/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/dg-DG/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/el-GR/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/en-GB/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/en-US/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/es-ES/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/et-EE/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/eu-ES/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/fa-IR/translation.json` (+3 -1) _...and 35 more files_ </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Hide decorative svgs from screen readers - Add high contrast mode on sensitive input - Add `aria-pressed` to toggle button - Add `<label` to password input (Only visible to screen readers `.sr-only`) - Aria label to `button` that only has an svg inside ### Added N/A ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos <img width="925" alt="Screenshot 2025-06-12 at 13 32 07" src="https://github.com/user-attachments/assets/7340dc45-a8eb-4cbd-921b-7cb7e3db5870" /> <img width="929" alt="Screenshot 2025-06-12 at 13 32 11" src="https://github.com/user-attachments/assets/11f221b1-3d8b-4e84-8763-36375fab2307" /> <img width="925" alt="Screenshot 2025-06-12 at 14 05 33" src="https://github.com/user-attachments/assets/fd00dc36-bb66-4e88-8115-cf2662ad3acd" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 19:04:57 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#10445
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?