[PR #14893] [MERGED] fix(tools): not all arguments converted during string formatting #10430

New Issue

GiteaMirror · 2025-11-11T19:04:35-06:00

GiteaMirror commented

2025-11-11 19:04:35 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14893
Author: @tcx4c70
Created: 6/11/2025
Status: ✅ Merged
Merged: 6/12/2025
Merged by: @tjbck

Base: dev ← Head: fix/log-format-error

📝 Commits (1)

809d91a fix(tools): not all arguments converted during string formatting

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/open_webui/utils/tools.py (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR fix a bug that output of tool calling is alwasy "not all arguments converted during string formatting" if any exception is throwed during calling tools.

Changed

backend/open_webui/utils/tools.py: Change 2 format strings to f-string (if we use format string, we need to add %s)

Fixed

output of tool calling is alwasy "not all arguments converted during string formatting" if any exception is throwed during calling tools.

Screenshots or Videos

Before the fix:

After the fix:

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14893 **Author:** [@tcx4c70](https://github.com/tcx4c70) **Created:** 6/11/2025 **Status:** ✅ Merged **Merged:** 6/12/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/log-format-error` --- ### 📝 Commits (1) - [`809d91a`](https://github.com/open-webui/open-webui/commit/809d91a3dfda915ea5c1ea7a577faac9f35728a9) fix(tools): not all arguments converted during string formatting ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/tools.py` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR fix a bug that output of tool calling is alwasy "not all arguments converted during string formatting" if any exception is throwed during calling tools. ### Changed - `backend/open_webui/utils/tools.py`: Change 2 format strings to f-string (if we use format string, we need to add `%s`) ### Fixed - output of tool calling is alwasy "not all arguments converted during string formatting" if any exception is throwed during calling tools. --- ### Screenshots or Videos Before the fix: <img width="960" alt="截屏2025-06-11 21 46 00" src="https://github.com/user-attachments/assets/d783d745-150c-4612-9e5c-6fbb051541a2" /> After the fix: <img width="1014" alt="截屏2025-06-11 21 48 10" src="https://github.com/user-attachments/assets/110a9b8b-b245-485f-8b5c-3ebaa1f32d85" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:04:35 -06:00

GiteaMirror closed this issue

2025-11-11 19:04:35 -06:00

GiteaMirror referenced this issue

2026-04-20 04:13:14 -05:00

[PR #10430] [CLOSED] Feat: Adding Support for Azure AI Document Intelligence for Content Extraction #22532

GiteaMirror referenced this issue

2026-04-20 04:13:49 -05:00

[PR #10486] [MERGED] Feat: Adding Support for Azure AI Document Intelligence for Content Extraction (Revised) #22546

GiteaMirror referenced this issue

2026-04-25 11:17:56 -05:00

[PR #10430] [CLOSED] Feat: Adding Support for Azure AI Document Intelligence for Content Extraction #38162