[PR #14728] [CLOSED] fix: resolve logout redirect issue by adding JSON response parsing #10364

New Issue

GiteaMirror · 2025-11-11T19:03:01-06:00

GiteaMirror commented

2025-11-11 19:03:01 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14728
Author: @ShirasawaSama
Created: 6/6/2025
Status: ❌ Closed

Base: dev ← Head: fix_logout_response_parsing

📝 Commits (1)

58f9114 fix: add missing .json() call to logout fetch request

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib/apis/auths/index.ts (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

The logout functionality was experiencing redirect failures, preventing users from being properly redirected to the expected page after logging out.

https://github.com/open-webui/open-webui/blob/main/src/lib/components/layout/Sidebar/UserMenu.svelte#L212

And

https://github.com/open-webui/open-webui/blob/main/src/routes/%2Blayout.svelte#L472

Investigation revealed that the logout fetch request was missing the .json() method call, resulting in redirect URL information being lost or malformed.

Added

[List any new features, functionalities, or additions]

Changed

[List any changes, updates, refactorings, or optimizations]

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

src/lib/apis/auths/index.ts: fix: resolve logout redirect issue by adding JSON response parsing

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14728 **Author:** [@ShirasawaSama](https://github.com/ShirasawaSama) **Created:** 6/6/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix_logout_response_parsing` --- ### 📝 Commits (1) - [`58f9114`](https://github.com/open-webui/open-webui/commit/58f91146139ef19075eb390b8dd7b27da209d36e) fix: add missing .json() call to logout fetch request ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/apis/auths/index.ts` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description The logout functionality was experiencing redirect failures, preventing users from being properly redirected to the expected page after logging out. https://github.com/open-webui/open-webui/blob/main/src/lib/components/layout/Sidebar/UserMenu.svelte#L212 ![image](https://github.com/user-attachments/assets/57ae1d47-3b4a-4c9b-9e73-94776a048655) And https://github.com/open-webui/open-webui/blob/main/src/routes/%2Blayout.svelte#L472 ![image](https://github.com/user-attachments/assets/b8e2bdab-1d27-4356-acaa-889c87cea6a8) Investigation revealed that the logout fetch request was missing the .json() method call, resulting in redirect URL information being lost or malformed. ### Added - [List any new features, functionalities, or additions] ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - **src/lib/apis/auths/index.ts**: fix: resolve logout redirect issue by adding JSON response parsing ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:03:01 -06:00

GiteaMirror closed this issue

2025-11-11 19:03:02 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#10364