github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-03-16 20:11:53 -05:00
Code Issues 308 Packages Projects Releases 100 Wiki Activity

[PR #14720] [MERGED] Feat: accessibible chat buttons #10362

New Issue
Closed
opened 2025-11-11 19:02:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 19:02:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14720
Author: @sinejespersen
Created: 6/6/2025
Status: ✅ Merged
Merged: 6/6/2025
Merged by: @tjbck

Base: dev ← Head: feature/accessibible-chat-buttons

📝 Commits (4)

  • dc60bd2 add aria-hidden to svg, as these are decorative
  • 2b4d4d2 remove aria-label from tooltip, as tippy handles this out of the box
  • fd97882 add aria labels to buttons that only contains decorative svgs
  • 9c38183 reindent xmlns

📊 Changes

4 files changed (+35 additions, -5 deletions)

View changed files

📝 src/lib/components/chat/Messages/ResponseMessage.svelte (+28 -0)
📝 src/lib/components/common/Tooltip.svelte (+1 -3)
📝 src/lib/i18n/locales/da-DK/translation.json (+3 -1)
📝 src/lib/i18n/locales/en-US/translation.json (+3 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Added

  • Add aria labels to buttons in chat

Changed

  • Remove svgs from screen readers (aria-hidden)

Deprecated

N/A

Removed

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

There is a. button that seem to only do console.logs, is this as expected?

Screenshots or Videos

N/A - no visible changes

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14720 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 6/6/2025 **Status:** ✅ Merged **Merged:** 6/6/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feature/accessibible-chat-buttons` --- ### 📝 Commits (4) - [`dc60bd2`](https://github.com/open-webui/open-webui/commit/dc60bd2816b4c3491a6c352066c3b03c4e9ac2c3) add aria-hidden to svg, as these are decorative - [`2b4d4d2`](https://github.com/open-webui/open-webui/commit/2b4d4d277041ab05237c10bb92a1e32642940414) remove aria-label from tooltip, as tippy handles this out of the box - [`fd97882`](https://github.com/open-webui/open-webui/commit/fd97882fca154d878c601ee67be9b6c364e62e06) add aria labels to buttons that only contains decorative svgs - [`9c38183`](https://github.com/open-webui/open-webui/commit/9c38183689ed886584206661ecb6a7288d9dab2b) reindent xmlns ### 📊 Changes **4 files changed** (+35 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/ResponseMessage.svelte` (+28 -0) 📝 `src/lib/components/common/Tooltip.svelte` (+1 -3) 📝 `src/lib/i18n/locales/da-DK/translation.json` (+3 -1) 📝 `src/lib/i18n/locales/en-US/translation.json` (+3 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Add aria labels to buttons in chat - Remove svgs from screen readers (`aria-hidden`) - Remove aria-label from tooltip as [tippy handles this out of the box](https://tippyjs.bootcss.com/accessibility/#announcing-tooltip-content) ### Added - Add aria labels to buttons in chat ### Changed - Remove svgs from screen readers (`aria-hidden`) ### Deprecated N/A ### Removed - Remove aria-label from tooltip as [tippy handles this out of the box](https://tippyjs.bootcss.com/accessibility/#announcing-tooltip-content) ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information [There is a. button that seem to only do console.logs, is this as expected?](https://github.com/open-webui/open-webui/blob/main/src/lib/components/chat/Messages/ResponseMessage.svelte#L1180) ### Screenshots or Videos N/A - no visible changes ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 19:02:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#10362
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?