[PR #14680] [CLOSED] fix: multiple mcp calls issue #10347

New Issue

GiteaMirror · 2025-11-11T19:02:30-06:00

GiteaMirror commented

2025-11-11 19:02:30 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14680
Author: @troyliu0105
Created: 6/5/2025
Status: ❌ Closed

Base: dev ← Head: bugfix/fix_multiple_mcp_calls

📝 Commits (1)

e2c4eea fix: multiple mcp calls issue

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+5 -5)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR is for to solve multiple mcp function calls in a single chat issue, like this #14583 and discussion here

Added

N/A

Changed

changed from "index" to "id" to check whether the call exists, and avoid multiple same function concat together improplerly.

Deprecated

N/A

Removed

N/A

Fixed

solved #14583

Security

N/A

Breaking Changes

maybe mcp call procedure

Additional Information

I think the "index" field is useless yet, so maybe "id" is more proper for identity.

Screenshots or Videos

before:
screenshot in the discussion

after:

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14680 **Author:** [@troyliu0105](https://github.com/troyliu0105) **Created:** 6/5/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `bugfix/fix_multiple_mcp_calls` --- ### 📝 Commits (1) - [`e2c4eea`](https://github.com/open-webui/open-webui/commit/e2c4eeafdfd4f2b77fa396f6cd55d454b8e1c85d) fix: multiple mcp calls issue ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+5 -5) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR is for to solve multiple mcp function calls in a single chat issue, like this #14583 and discussion [here](https://github.com/open-webui/open-webui/discussions/14590) ### Added N/A ### Changed - changed from "index" to "id" to check whether the call exists, and avoid multiple same function concat together improplerly. ### Deprecated - N/A ### Removed - N/A ### Fixed - solved #14583 ### Security N/A ### Breaking Changes - maybe mcp call procedure --- ### Additional Information - I think the "index" field is useless yet, so maybe "id" is more proper for identity. ### Screenshots or Videos before: *screenshot in the discussion* ![image](https://github.com/user-attachments/assets/9ba1d903-79f9-4a4a-8fb5-a706e7e439c1) after: ![image](https://github.com/user-attachments/assets/e7bcb328-6248-4340-a8f8-7e26dd80b2a6) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 19:02:30 -06:00

GiteaMirror closed this issue

2025-11-11 19:02:30 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#10347