[PR #14288] [CLOSED] feat: Optionally hide private workspace items from admins #10230

Closed
opened 2025-11-11 18:59:33 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14288
Author: @Classic298
Created: 5/24/2025
Status: ❌ Closed

Base: dev ← Head: HideWorkspaceAdmin


📝 Commits (10+)

📊 Changes

5 files changed (+164 additions, -14 deletions)

View changed files

📝 backend/open_webui/config.py (+4 -0)
📝 backend/open_webui/routers/knowledge.py (+27 -3)
📝 backend/open_webui/routers/models.py (+13 -1)
📝 backend/open_webui/routers/prompts.py (+25 -2)
📝 backend/open_webui/routers/tools.py (+95 -8)

📄 Description

Pull Request Checklist

Related issue:

https://github.com/open-webui/open-webui/discussions/14083

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources? https://github.com/open-webui/docs/pull/560
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • feat: Introduces a new feature or enhancement to the codebase

Changelog Entry

Description

  • Prev.: If a user created a private item in a workspace section (private prompt, private tool, private knowledgebase, private model), then any admin would always see all items, even if set to private and not shared with any group.
    • This would lead to clutterered UI, obstruct the admin's ability to manage workspaces properly in larger instances
    • Admin does not need to see private user's items - the introduction of a feature to hide private objects would lead to more privacy for users
      • Users would potentially expect private items to be somewhat private

Fixes: https://github.com/open-webui/open-webui/discussions/14083

Added

  • Added a new env var to optionally hide all workspace items that are "private" from all admins.

Changed

  • If the env var is not set, current behaviour does not change.

Security

  • Optional privacy improvements for users.

Additional Information

  • Behaviour of prompts/knowledge/etc. that is shared WITH A GROUP does not change
    • Admins are, by default, member of all groups. So if a user creates a prompt and shares it with a group, the admins will see that workspace item.
    • Only if the workspace item was created with "private" permissions and the env var is set, will it be hidden from admins.

Related docs PR: https://github.com/open-webui/docs/pull/560

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14288 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 5/24/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `HideWorkspaceAdmin` --- ### 📝 Commits (10+) - [`8031d17`](https://github.com/open-webui/open-webui/commit/8031d17bacfd429d1c29d8f33c7a9f2dab203068) refactor: Update admin workspace access control (#4) - [`649b5a4`](https://github.com/open-webui/open-webui/commit/649b5a4bf0e224475b435319527301655ef2e767) Update tools.py - [`0313884`](https://github.com/open-webui/open-webui/commit/0313884d255cfbb6f1b60dd7c568d7af700c1e88) Update models.py - [`2ed97fa`](https://github.com/open-webui/open-webui/commit/2ed97faf3657a40a2a3eae469c7a256c130cad43) Update knowledge.py - [`739ee44`](https://github.com/open-webui/open-webui/commit/739ee443b7e6097968842d4e27a148b4cc71af65) Update knowledge.py - [`5dcc9f2`](https://github.com/open-webui/open-webui/commit/5dcc9f24fa237e70530e267e5a3ed4539920bc20) Update prompts.py - [`64989d7`](https://github.com/open-webui/open-webui/commit/64989d727e44cc077875fb7df64053ea98b1bc70) Update knowledge.py - [`597c83f`](https://github.com/open-webui/open-webui/commit/597c83fa7eba9f8d2dcffeb3536bbfef116efa2e) Update knowledge.py - [`5d27001`](https://github.com/open-webui/open-webui/commit/5d270019246bfb432d63f8ec09f214a73737c77a) Update models.py - [`f659a05`](https://github.com/open-webui/open-webui/commit/f659a05b6da394df004f67cd9a357878ca125c86) Update prompts.py ### 📊 Changes **5 files changed** (+164 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+4 -0) 📝 `backend/open_webui/routers/knowledge.py` (+27 -3) 📝 `backend/open_webui/routers/models.py` (+13 -1) 📝 `backend/open_webui/routers/prompts.py` (+25 -2) 📝 `backend/open_webui/routers/tools.py` (+95 -8) </details> ### 📄 Description # Pull Request Checklist ### Related issue: https://github.com/open-webui/open-webui/discussions/14083 **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? https://github.com/open-webui/docs/pull/560 - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **feat**: Introduces a new feature or enhancement to the codebase # Changelog Entry ### Description - Prev.: If a user created a private item in a workspace section (private prompt, private tool, private knowledgebase, private model), then any admin would always see all items, even if set to private and not shared with any group. - This would lead to clutterered UI, obstruct the admin's ability to manage workspaces properly in larger instances - Admin does not need to see private user's items - the introduction of a feature to hide private objects would lead to more privacy for users - Users would potentially expect private items to be somewhat private Fixes: https://github.com/open-webui/open-webui/discussions/14083 ### Added - Added a new env var to optionally hide all workspace items that are "private" from all admins. ### Changed - If the env var is not set, current behaviour does not change. ### Security - Optional privacy improvements for users. --- ### Additional Information - Behaviour of prompts/knowledge/etc. that is shared WITH A GROUP does not change - Admins are, by default, member of all groups. So if a user creates a prompt and shares it with a group, the admins will see that workspace item. - Only if the workspace item was created with "private" permissions and the env var is set, will it be hidden from admins. Related docs PR: https://github.com/open-webui/docs/pull/560 ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:59:33 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#10230