github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-08 04:16:03 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #13940] [CLOSED] Fix tools user valves so it won't be overridden when many tools installed #10134

New Issue
Closed
opened 2025-11-11 18:57:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-11 18:57:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13940
Author: @anhlt
Created: 5/16/2025
Status: ❌ Closed

Base: dev ← Head: hotfix/fix_tools_user_valves

📝 Commits (1)

  • 402905d - update the user valves dict instead of creating new one

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/open_webui/utils/tools.py (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Fixed

  • Instead of create new dict for user valves, we should update it

Security

  • [List any new or updated security-related changes, including vulnerability fixes]

Additional Information

Currently I'm try to create tools with UserValves configuration, but I couldn't access the UserValve Key in Tools.
this is debug message when I try to log the user['valves']

{'id': 'ff8bea74-18ef-49a7-a483-e4e6bcded769', 'email': 'floral-vom', 'name': 'xx', 'role': 'user', 'valves': UserValves(CLEAN_CONTENT=True, JINA_API_KEY='', YOUTUBE_LANGUAGE='en')}

this is my user settings in database

    "tools": {
        "valves": {
            "universal_scraper": {
                "CLEAN_CONTENT": true,
                "JINA_API_KEY": "",
                "YOUTUBE_LANGUAGE": "en"
            },
            "knowledge_manager": {
                "OPENWEBUI_KEY": "eJM",
                "test_user_valve": false
            }
        }
    }

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13940 **Author:** [@anhlt](https://github.com/anhlt) **Created:** 5/16/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `hotfix/fix_tools_user_valves` --- ### 📝 Commits (1) - [`402905d`](https://github.com/open-webui/open-webui/commit/402905d6c3305ffb69ff31a59e52551d97b2ab0a) - update the user valves dict instead of creating new one ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/tools.py` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Fixed - Instead of create new dict for user valves, we should update it ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Additional Information Currently I'm try to create tools with UserValves configuration, but I couldn't access the UserValve Key in Tools. this is debug message when I try to log the __user__['valves'] ```bash {'id': 'ff8bea74-18ef-49a7-a483-e4e6bcded769', 'email': 'floral-vom', 'name': 'xx', 'role': 'user', 'valves': UserValves(CLEAN_CONTENT=True, JINA_API_KEY='', YOUTUBE_LANGUAGE='en')} ``` this is my user settings in database ```json "tools": { "valves": { "universal_scraper": { "CLEAN_CONTENT": true, "JINA_API_KEY": "", "YOUTUBE_LANGUAGE": "en" }, "knowledge_manager": { "OPENWEBUI_KEY": "eJM", "test_user_valve": false } } } ``` ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-11 18:57:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#10134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?