[PR #13643] [MERGED] fix: Add S3_ENABLE_TAGGING env variable and fix S3_USE_ACCELERATE_ENDPOINT Type Error #10052

New Issue

GiteaMirror · 2025-11-11T18:38:06-06:00

GiteaMirror commented

2025-11-11 18:38:06 -06:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13643
Author: @suleimanelkhoury
Created: 5/7/2025
Status: ✅ Merged
Merged: 5/7/2025
Merged by: @tjbck

Base: dev ← Head: S3-tagging-boto3

📝 Commits (2)

7620a6b Update config.py
ccc64ac Update provider.py

📊 Changes

2 files changed (+12 additions, -9 deletions)

View changed files

📝 backend/open_webui/config.py (+2 -1)
📝 backend/open_webui/storage/provider.py (+10 -8)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

As per https://github.com/open-webui/open-webui/discussions/13548

Fixed S3 Storage Compatibility Issues with Cloudflare R2 and with S3 Storages without PutObjectTagging permissions Leading to Upload Failures.
Fixed Acceleration type error.

Added

S3_ENABLE_TAGGING environment variable to choose if the Storage supports or has tagging permissions (like in Cloudflare R2).

Fixed

Fixed S3_USE_ACCELERATE_ENDPOINT default value from "False" to "false", since boto3 expects a Python bool, not a string.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13643 **Author:** [@suleimanelkhoury](https://github.com/suleimanelkhoury) **Created:** 5/7/2025 **Status:** ✅ Merged **Merged:** 5/7/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `S3-tagging-boto3` --- ### 📝 Commits (2) - [`7620a6b`](https://github.com/open-webui/open-webui/commit/7620a6bf8c62c868f56e7ce87ac284327b6b31f6) Update config.py - [`ccc64ac`](https://github.com/open-webui/open-webui/commit/ccc64ac6b772a09945ef9b0f283956c1ccf5f1ec) Update provider.py ### 📊 Changes **2 files changed** (+12 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+2 -1) 📝 `backend/open_webui/storage/provider.py` (+10 -8) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description As per https://github.com/open-webui/open-webui/discussions/13548 - Fixed S3 Storage Compatibility Issues with Cloudflare R2 and with S3 Storages without PutObjectTagging permissions Leading to Upload Failures. - Fixed Acceleration type error. ### Added - S3_ENABLE_TAGGING environment variable to choose if the Storage supports or has tagging permissions (like in Cloudflare R2). ### Fixed - Fixed S3_USE_ACCELERATE_ENDPOINT default value from "False" to "false", since boto3 expects a Python bool, not a string. --- ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-11 18:38:06 -06:00

GiteaMirror closed this issue

2025-11-11 18:38:07 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#10052