github-starred/olm
2
0
Fork 0
mirror of https://github.com/fosrl/olm.git synced 2026-05-06 10:47:55 -05:00
Code Issues 61 Packages Projects Releases 15 Wiki Activity

[PR #74] [MERGED] feat(logger): add log file switch to olm config #76

New Issue
Closed
opened 2026-04-13 01:15:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 01:15:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/olm/pull/74
Author: @water-sucks
Created: 1/10/2026
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @oschwartz10612

Base: dev ← Head: add-log-file-switch

📝 Commits (2)

  • 11ee46e chore: format files using gofmt
  • d64b7bf feat(logger): configure log file path thorugh global options

📊 Changes

6 files changed (+56 additions, -46 deletions)

View changed files

📝 dns/dns_proxy.go (+5 -5)
📝 dns/dns_records.go (+1 -1)
📝 dns/dns_records_test.go (+34 -34)
📝 dns/platform/darwin.go (+1 -1)
📝 olm/olm.go (+13 -4)
📝 olm/types.go (+2 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This adds a log file path option to the olm config struct so that it does not have to be configured directly using the newt package.

This enables removal of the explicit newt dependency for upstream packages that require it, such as pangolin-cli and other client projects.

I also ran a pass of gofmt on the project.

How to test?

Pass in a log file path in the olm.GlobalConfig struct and make sure it gets used when logging.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/olm/pull/74 **Author:** [@water-sucks](https://github.com/water-sucks) **Created:** 1/10/2026 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `add-log-file-switch` --- ### 📝 Commits (2) - [`11ee46e`](https://github.com/fosrl/olm/commit/11ee46e0b50cdcc60cb4d97a0524ac19f1010b04) chore: format files using gofmt - [`d64b7bf`](https://github.com/fosrl/olm/commit/d64b7bf8646c41cd894dd7a73640d6fb75ae525d) feat(logger): configure log file path thorugh global options ### 📊 Changes **6 files changed** (+56 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `dns/dns_proxy.go` (+5 -5) 📝 `dns/dns_records.go` (+1 -1) 📝 `dns/dns_records_test.go` (+34 -34) 📝 `dns/platform/darwin.go` (+1 -1) 📝 `olm/olm.go` (+13 -4) 📝 `olm/types.go` (+2 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This adds a log file path option to the `olm` config struct so that it does not have to be configured directly using the `newt` package. This enables removal of the explicit `newt` dependency for upstream packages that require it, such as `pangolin-cli` and other client projects. I also ran a pass of `gofmt` on the project. ## How to test? Pass in a log file path in the `olm.GlobalConfig` struct and make sure it gets used when logging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 01:15:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
documentation
enhancement
good first issue
help wanted
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/olm#76
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?