github-starred/olm
2
0
Fork 0
mirror of https://github.com/fosrl/olm.git synced 2026-05-06 02:37:55 -05:00
Code Issues 61 Packages Projects Releases 15 Wiki Activity

[PR #100] [MERGED] feat(DNS): Add static cleanup funcs #661

New Issue
Closed
opened 2026-05-05 10:26:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 10:26:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/olm/pull/100
Author: @LaurenceJJones
Created: 3/12/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @oschwartz10612

Base: main ← Head: fix/issue-38-stale-dns-cleanup

📝 Commits (2)

  • 8549dc8 enhance(dns): expose stale cleanup functionality
  • f250702 feat(DNS): Add static cleanup funcs

📊 Changes

9 files changed (+245 additions, -2 deletions)

View changed files

📝 dns/override/dns_override_android.go (+7 -1)
📝 dns/override/dns_override_darwin.go (+17 -0)
📝 dns/override/dns_override_ios.go (+7 -1)
📝 dns/override/dns_override_unix.go (+46 -0)
📝 dns/override/dns_override_windows.go (+16 -0)
📝 dns/platform/darwin.go (+56 -0)
📝 dns/platform/file.go (+24 -0)
📝 dns/platform/network_manager.go (+38 -0)
📝 dns/platform/resolvconf.go (+34 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Add static cleanup functions inside olm so other implementations can invoke these to cleanup configuration of olm without explicitly needing to know which configuration olm creates.

How to test?

Currently this is purely just a SDK improvement to which the CLI will need to implement these as either prerun hooks to up and down or we add a pangolin cleanup function so it explicit.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/olm/pull/100 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 3/12/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `fix/issue-38-stale-dns-cleanup` --- ### 📝 Commits (2) - [`8549dc8`](https://github.com/fosrl/olm/commit/8549dc87460159da1305c8f80338ca859a9bceda) enhance(dns): expose stale cleanup functionality - [`f250702`](https://github.com/fosrl/olm/commit/f250702177d2b92db2ae92392e51b3af65793df5) feat(DNS): Add static cleanup funcs ### 📊 Changes **9 files changed** (+245 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `dns/override/dns_override_android.go` (+7 -1) 📝 `dns/override/dns_override_darwin.go` (+17 -0) 📝 `dns/override/dns_override_ios.go` (+7 -1) 📝 `dns/override/dns_override_unix.go` (+46 -0) 📝 `dns/override/dns_override_windows.go` (+16 -0) 📝 `dns/platform/darwin.go` (+56 -0) 📝 `dns/platform/file.go` (+24 -0) 📝 `dns/platform/network_manager.go` (+38 -0) 📝 `dns/platform/resolvconf.go` (+34 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Add static cleanup functions inside olm so other implementations can invoke these to cleanup configuration of olm without explicitly needing to know which configuration olm creates. ## How to test? Currently this is purely just a SDK improvement to which the CLI will need to implement these as either prerun hooks to `up` and `down` or we add a `pangolin cleanup` function so it explicit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 10:26:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
documentation
enhancement
good first issue
help wanted
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/olm#661
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?