[PR #96] [CLOSED] fix(dns): ensure AAAA query return nodata response #465

New Issue

GiteaMirror · 2026-04-25T02:00:11-05:00

GiteaMirror commented

2026-04-25 02:00:11 -05:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/olm/pull/96
Author: @LaurenceJJones
Created: 2/26/2026
Status: ❌ Closed

Base: main ← Head: fix/dns-nodata-response

📝 Commits (1)

06f3c0a fix(dns): ensure AAAA records return nodata response

📊 Changes

2 files changed (+195 additions, -0 deletions)

View changed files

📝 dns/dns_proxy.go (+17 -0)
➕ dns/dns_proxy_test.go (+178 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

fix: https://github.com/orgs/fosrl/discussions/2533

Return authoritative NOERROR with an empty answer (NODATA) when a local name exists only for the opposite A/AAAA type, instead of forwarding upstream (which is where the NXDOMAIN was being responded from). Add coverage for A-only, AAAA-only, wildcard matches, and non-existent domains to preserve upstream NXDOMAIN behavior.

How to test?

Added golang tests to ensure correct behavior is performed, however, for manual testing you can spin up an olm container and an alpine container that uses the same network namespace. Using tools outlined in the issue should not fail dns resolution for any alias entries.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/olm/pull/96 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 2/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/dns-nodata-response` --- ### 📝 Commits (1) - [`06f3c0a`](https://github.com/fosrl/olm/commit/06f3c0ad686da26aeecbbbdba800baf808e52c93) fix(dns): ensure AAAA records return nodata response ### 📊 Changes **2 files changed** (+195 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `dns/dns_proxy.go` (+17 -0) ➕ `dns/dns_proxy_test.go` (+178 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description fix: https://github.com/orgs/fosrl/discussions/2533 Return authoritative NOERROR with an empty answer (NODATA) when a local name exists only for the opposite A/AAAA type, instead of forwarding upstream (which is where the NXDOMAIN was being responded from). Add coverage for A-only, AAAA-only, wildcard matches, and non-existent domains to preserve upstream NXDOMAIN behavior. ## How to test? Added golang tests to ensure correct behavior is performed, however, for manual testing you can spin up an olm container and an alpine container that uses the same network namespace. Using tools outlined in the issue should not fail dns resolution for any alias entries. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 02:00:11 -05:00

GiteaMirror closed this issue

2026-04-25 02:00:12 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/olm#465