github-starred/olm
2
0
Fork 0
mirror of https://github.com/fosrl/olm.git synced 2026-03-09 07:13:10 -05:00
Code Issues 9 Packages Projects Releases 7 Wiki Activity

[PR #26] [MERGED] fix: add ipv6 endpoint formatter #36

New Issue
Closed
opened 2025-11-19 07:04:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-19 07:04:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/olm/pull/26
Author: @kevin-gillet
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @oschwartz10612

Base: main ← Head: 25-fix-olm-ipv6-parsing

📝 Commits (2)

  • 5b443a4 fix: add ipv6 endpoint formatter
  • e669d54 fix: remove comment

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 peermonitor/peermonitor.go (+8 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

To resolve https://github.com/fosrl/olm/issues/25

How to test?

I tested i by running GOOS=linux GOARCH=amd64 go build ., got the binary, replaced the one on my server and established connection from Olm to Pangolin relay (Gerbil) only via ipv6.

Proof Of Work :

root@debian13-amd64:~# systemctl status olm --no-pager -l
● olm.service - Olm
     Loaded: loaded (/etc/systemd/system/olm.service; disabled; preset: enabled)
     Active: active (running) since Thu 2025-09-04 14:07:08 CEST; 6min ago
 Invocation: 95b9893a92304054bbffe49d194d6d4b
   Main PID: 2180396 (olm)
      Tasks: 16 (limit: 76567)
     Memory: 9.3M (peak: 10.8M)
        CPU: 83ms
     CGroup: /system.slice/olm.service
             └─2180396 /usr/local/bin/olm --id <redacted> --secret <redacted> --endpoint https://<redacted> --holepunch

Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Sent initial ping message
Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Starting hole punch for 1 exit nodes
Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Starting UDP hole punch to 1 exit nodes
Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Resolved exit node: <redacted> -> [<redacted>]:21820
Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 Starting hole punch for 1 exit nodes
Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 Stopping UDP holepunch for all exit nodes
Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 UDP hole punch goroutine ended for all exit nodes
Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 UDP hole punch goroutine ended
Sep 04 14:07:10 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:10 UAPI listener started
Sep 04 14:07:10 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:10 WireGuard device created.

Here you can see the ipv6 is in brackets and the wireguard tunnel is correctly establishing without error.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/olm/pull/26 **Author:** [@kevin-gillet](https://github.com/kevin-gillet) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `25-fix-olm-ipv6-parsing` --- ### 📝 Commits (2) - [`5b443a4`](https://github.com/fosrl/olm/commit/5b443a41a3c7d88a33aef0febf40196772f91eb5) fix: add ipv6 endpoint formatter - [`e669d54`](https://github.com/fosrl/olm/commit/e669d543c42d9779939386289bcdc5a10e11b61c) fix: remove comment ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `peermonitor/peermonitor.go` (+8 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description To resolve https://github.com/fosrl/olm/issues/25 ## How to test? I tested i by running `GOOS=linux GOARCH=amd64 go build .`, got the binary, replaced the one on my server and established connection from Olm to Pangolin relay (Gerbil) only via ipv6. ## Proof Of Work : ``` root@debian13-amd64:~# systemctl status olm --no-pager -l ● olm.service - Olm Loaded: loaded (/etc/systemd/system/olm.service; disabled; preset: enabled) Active: active (running) since Thu 2025-09-04 14:07:08 CEST; 6min ago Invocation: 95b9893a92304054bbffe49d194d6d4b Main PID: 2180396 (olm) Tasks: 16 (limit: 76567) Memory: 9.3M (peak: 10.8M) CPU: 83ms CGroup: /system.slice/olm.service └─2180396 /usr/local/bin/olm --id <redacted> --secret <redacted> --endpoint https://<redacted> --holepunch Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Sent initial ping message Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Starting hole punch for 1 exit nodes Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Starting UDP hole punch to 1 exit nodes Sep 04 14:07:08 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:08 Resolved exit node: <redacted> -> [<redacted>]:21820 Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 Starting hole punch for 1 exit nodes Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 Stopping UDP holepunch for all exit nodes Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 UDP hole punch goroutine ended for all exit nodes Sep 04 14:07:09 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:09 UDP hole punch goroutine ended Sep 04 14:07:10 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:10 UAPI listener started Sep 04 14:07:10 debian13-amd64 olm[2180396]: INFO: 2025/09/04 14:07:10 WireGuard device created. ``` Here you can see the ipv6 is in brackets and the wireguard tunnel is correctly establishing without error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-19 07:04:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/olm#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?