github-starred/olm
2
0
Fork 0
mirror of https://github.com/fosrl/olm.git synced 2026-05-06 10:47:55 -05:00
Code Issues 61 Packages Projects Releases 15 Wiki Activity

[GH-ISSUE #106] handleWgPeerUpdate does not merge alias updates #318

New Issue
Open
opened 2026-04-23 01:55:03 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-23 01:55:03 -05:00
Owner
Copy Link

Originally created by @LaurenceJJones on GitHub (Mar 20, 2026).
Original GitHub issue: https://github.com/fosrl/olm/issues/106

In handleWgPeerUpdate

703fe4fe5d/olm/peer.go (L117-L185)

we merge several mutable fields from peers.SiteConfig, but we never copy Aliases.

As a result, alias changes delivered via the update-peer websocket path never reach PeerManager.UpdatePeer(), even though UpdatePeer() already removes and re-adds alias DNS records when siteConfig.Aliases changes.

Expected:

  • alias additions/removals/renames in update-peer should update the local DNS store

Actual:

  • alias updates are ignored in this path because siteConfig.Aliases is never merged
Originally created by @LaurenceJJones on GitHub (Mar 20, 2026). Original GitHub issue: https://github.com/fosrl/olm/issues/106 In handleWgPeerUpdate https://github.com/fosrl/olm/blob/703fe4fe5de8957ac35f8f45df10a680845402fb/olm/peer.go#L117-L185 we merge several mutable fields from peers.SiteConfig, but we never copy Aliases. As a result, alias changes delivered via the update-peer websocket path never reach PeerManager.UpdatePeer(), even though UpdatePeer() already removes and re-adds alias DNS records when siteConfig.Aliases changes. Expected: - alias additions/removals/renames in update-peer should update the local DNS store Actual: - alias updates are ignored in this path because siteConfig.Aliases is never merged
GiteaMirror added the bugneeds investigating labels 2026-04-23 01:55:04 -05:00
GiteaMirror commented 2026-04-23 01:55:05 -05:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Apr 4, 2026):

This issue has been automatically marked as stale due to 14 days of inactivity. It will be closed in 14 days if no further activity occurs.

<!-- gh-comment-id:4185844115 --> @github-actions[bot] commented on GitHub (Apr 4, 2026): This issue has been automatically marked as stale due to 14 days of inactivity. It will be closed in 14 days if no further activity occurs.
GiteaMirror commented 2026-04-23 01:55:05 -05:00
Author
Owner
Copy Link

@LaurenceJJones commented on GitHub (Apr 6, 2026):

Adding to triage and commenting to remove stale tag

<!-- gh-comment-id:4191769433 --> @LaurenceJJones commented on GitHub (Apr 6, 2026): Adding to triage and commenting to remove stale tag
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
documentation
enhancement
good first issue
help wanted
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
No Label bug needs investigating
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/olm#318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?