github-starred/olm
2
0
Fork 0
mirror of https://github.com/fosrl/olm.git synced 2026-07-15 21:42:43 -05:00
Code Issues 204 Packages Projects Releases 18 Wiki Activity

[PR #126] [MERGED] Handle remove on a per site level correctly #2494

New Issue
Closed
opened 2026-07-12 11:59:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-12 11:59:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/olm/pull/126
Author: @oschwartz10612
Created: 6/25/2026
Status: ✅ Merged
Merged: 6/25/2026
Merged by: @oschwartz10612

Base: main ← Head: dev

📝 Commits (3)

  • 5537798 Dont remove alias if used by other peers
  • f02045d Aliases are by site
  • f87b804 Merge branch 'main' into dev

📊 Changes

4 files changed (+111 additions, -3 deletions)

View changed files

📝 dns/dns_proxy.go (+6 -0)
📝 dns/dns_records.go (+73 -2)
📝 dns/dns_records_test.go (+31 -0)
📝 peers/manager.go (+1 -1)

📄 Description

  • Dont remove alias if used by other peers
  • Aliases are by site

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/olm/pull/126 **Author:** [@oschwartz10612](https://github.com/oschwartz10612) **Created:** 6/25/2026 **Status:** ✅ Merged **Merged:** 6/25/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (3) - [`5537798`](https://github.com/fosrl/olm/commit/55377980b874a61785bf285c0df8b4c072eb674a) Dont remove alias if used by other peers - [`f02045d`](https://github.com/fosrl/olm/commit/f02045d936a07306af0db528d07ed0b5b6d9009a) Aliases are by site - [`f87b804`](https://github.com/fosrl/olm/commit/f87b804051be3de55c8b37ea10c655dbb2f83ddd) Merge branch 'main' into dev ### 📊 Changes **4 files changed** (+111 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `dns/dns_proxy.go` (+6 -0) 📝 `dns/dns_records.go` (+73 -2) 📝 `dns/dns_records_test.go` (+31 -0) 📝 `peers/manager.go` (+1 -1) </details> ### 📄 Description - **Dont remove alias if used by other peers** - **Aliases are by site** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-12 11:59:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
documentation
enhancement
good first issue
help wanted
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/olm#2494
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?