we merge several mutable fields from peers.SiteConfig, but we never copy Aliases.
As a result, alias changes delivered via the update-peer websocket path never reach PeerManager.UpdatePeer(), even though UpdatePeer() already removes and re-adds alias DNS records when siteConfig.Aliases changes.
Expected:
alias additions/removals/renames in update-peer should update the local DNS store
Actual:
alias updates are ignored in this path because siteConfig.Aliases is never merged
Originally created by @LaurenceJJones on GitHub (Mar 20, 2026).
Original GitHub issue: https://github.com/fosrl/olm/issues/106
In handleWgPeerUpdate
https://github.com/fosrl/olm/blob/703fe4fe5de8957ac35f8f45df10a680845402fb/olm/peer.go#L117-L185
we merge several mutable fields from peers.SiteConfig, but we never copy Aliases.
As a result, alias changes delivered via the update-peer websocket path never reach PeerManager.UpdatePeer(), even though UpdatePeer() already removes and re-adds alias DNS records when siteConfig.Aliases changes.
Expected:
- alias additions/removals/renames in update-peer should update the local DNS store
Actual:
- alias updates are ignored in this path because siteConfig.Aliases is never merged
@github-actions[bot] commented on GitHub (Apr 4, 2026):
This issue has been automatically marked as stale due to 14 days of inactivity. It will be closed in 14 days if no further activity occurs.
<!-- gh-comment-id:4185844115 -->
@github-actions[bot] commented on GitHub (Apr 4, 2026):
This issue has been automatically marked as stale due to 14 days of inactivity. It will be closed in 14 days if no further activity occurs.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @LaurenceJJones on GitHub (Mar 20, 2026).
Original GitHub issue: https://github.com/fosrl/olm/issues/106
In handleWgPeerUpdate
https://github.com/fosrl/olm/blob/703fe4fe5de8957ac35f8f45df10a680845402fb/olm/peer.go#L117-L185
we merge several mutable fields from peers.SiteConfig, but we never copy Aliases.
As a result, alias changes delivered via the update-peer websocket path never reach PeerManager.UpdatePeer(), even though UpdatePeer() already removes and re-adds alias DNS records when siteConfig.Aliases changes.
Expected:
Actual:
@github-actions[bot] commented on GitHub (Apr 4, 2026):
This issue has been automatically marked as stale due to 14 days of inactivity. It will be closed in 14 days if no further activity occurs.
@LaurenceJJones commented on GitHub (Apr 6, 2026):
Adding to triage and commenting to remove stale tag