Files
ollama/model/renderers/renderer_test.go
Daniel HiltgenandGitHub f52b9e742d Update gemma renderers (#19241)
* renderers: add gemma4-nemotron renderer

Add a Gemma 4 renderer variant that renders assistant content before
its tool calls rather than after the tool responses. Models opt in with
RENDERER gemma4-nemotron; gemma4 auto-detection is unchanged.

Adds the corresponding chat template as a test fixture for Jinja parity
checks.

* mlx: support Gemma 4 targets with DFlash drafts

Load a draft-owned output head when its config requires one, while preserving the target-head path used by existing DFlash models.

Expose Gemma 4 hidden-state taps and raw logits for speculative decoding. Report safetensors target precision independently of quantized draft weights.
2026-10-23 07:12:11 -07:00

119 lines
3.0 KiB
Go
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
package renderers
import (
"testing"
"github.com/ollama/ollama/api"
"github.com/ollama/ollama/types/model"
)
type mockRenderer struct{}
func (m *mockRenderer) Render(msgs []api.Message, tools []api.Tool, think *api.ThinkValue) (string, error) {
return "mock-output", nil
}
func (m *mockRenderer) LeadingBOS() string {
return ""
}
func TestRegisterCustomRenderer(t *testing.T) {
t.Cleanup(func() { delete(registry.renderers, "custom-renderer") })
// Register a custom renderer
Register("custom-renderer", func() Renderer {
return &mockRenderer{}
})
// Retrieve and use it
result, err := RenderWithRenderer("custom-renderer", nil, nil, nil)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if result != "mock-output" {
t.Errorf("expected 'mock-output', got %q", result)
}
}
func TestBuiltInRendererStillWorks(t *testing.T) {
tests := []struct {
name string
}{
{name: "qwen3-coder"},
{name: "qwen3.5"},
{name: "qwen3.8"},
{name: "nemotron-3-nano"},
{name: "nemotron-3.5-nano"},
}
messages := []api.Message{
{Role: "user", Content: "Hello"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result, err := RenderWithRenderer(tt.name, messages, nil, nil)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if result == "" {
t.Fatalf("expected non-empty result from %s renderer", tt.name)
}
})
}
}
func TestLeadingBOSForRenderer(t *testing.T) {
tests := []struct {
name string
want string
}{
{name: "gemma4", want: "<bos>"},
{name: "gemma4-small", want: "<bos>"},
{name: "gemma4-large", want: "<bos>"},
{name: "gemma4-nemotron", want: "<bos>"},
{name: "functiongemma", want: "<bos>"},
{name: "lfm2", want: "<|startoftext|>"},
{name: "lfm2-thinking", want: "<|startoftext|>"},
{name: "laguna", want: "〈|EOS|〉"},
{name: "poolside-v1", want: "〈|EOS|〉"},
{name: "deepseek3.1", want: "<|begin▁of▁sentence|>"},
{name: "cogito", want: "<|begin▁of▁sentence|>"},
{name: "qwen3-coder", want: ""},
{name: "unknown", want: ""},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := LeadingBOSForRenderer(tt.name); got != tt.want {
t.Fatalf("LeadingBOSForRenderer(%q) = %q, want %q", tt.name, got, tt.want)
}
})
}
}
func TestOverrideBuiltInRenderer(t *testing.T) {
t.Cleanup(func() { delete(registry.renderers, "qwen3-coder") })
// Override the built-in renderer
Register("qwen3-coder", func() Renderer {
return &mockRenderer{}
})
// Should get the override
result, err := RenderWithRenderer("qwen3-coder", nil, nil, nil)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if result != "mock-output" {
t.Errorf("expected 'mock-output' from override, got %q", result)
}
}
func TestUnknownRendererReturnsError(t *testing.T) {
_, err := RenderWithRenderer("nonexistent-renderer", nil, nil, nil)
if err == nil {
t.Error("expected error for unknown renderer")
}
}
func (m *mockRenderer) Thinking() *model.Thinking { return nil }