Files
ollama/create/laguna.go
Jesse Gross 2e036e7cdf mlx, mlxrunner: move the MLX engine out of x/
The MLX runner is the only Go inference runner left and is no longer
experimental, so its packages leave x/. The bindings become a top-level
mlx package beside the carried patches in mlx/compat, mirroring how
llama/ holds the llama.cpp integration, and the runner becomes mlxrunner
with the architectures nested under the package they implement.
Subpackages move with their parent unless listed.

  x/mlxrunner/mlx            mlx
  x/internal/mlxthread       mlx/mlxthread
  x/internal/mlxthreadtest   mlx/mlxthread/mlxthreadtest
  x/internal/mlxtest         mlx/mlxtest
  x/quant                    mlx/quant
  mlx/compat/*.patch         mlx/compat/mlx-c   (MLX patches go in mlx/compat/mlx)
  x/mlxrunner                mlxrunner
  x/models/nn                mlxrunner/nn
  x/models/<arch>            mlxrunner/model/<arch>
  x/mlxrunner/imports.go     mlxrunner/model/architectures   (new package)
  x/create                   create
  x/safetensors              fs/safetensors
  x/tokenizer                mlxrunner/tokenizer

Every package keeps its name, so the Go changes are the import path
rewrites the moves force, and the CMake, Dockerfile, CI cache keys, drift
check and Darwin payload script follow the new paths. Four edits are not
paths: the runner's blank architecture imports become the package
mlxrunner/model/architectures, so the list to extend for a new model sits
beside the architecture directories; a depguard rule keeps the two test
harnesses out of non-test code, as the x/internal placement used to; the
CI change filter's two entries for the long-deleted x/imagegen/mlx now
name the bindings' CMake project and the carried patches, so a change to
either builds the payload; and the tokenizer parity test reads its
fixtures from its own testdata instead of walking out of x/.

x/server and x/imagegen/manifest stay for the next two commits.
2026-09-16 14:06:08 -07:00

166 lines
5.1 KiB
Go

package create
import (
"encoding/json"
"fmt"
"strings"
)
type lagunaImportTransform struct {
denseMLPLayers map[int]bool
numLayers int
}
type lagunaConfig struct {
NumHiddenLayers int `json:"num_hidden_layers"`
MLPOnlyLayers []int `json:"mlp_only_layers"`
MLPLayerTypes []string `json:"mlp_layer_types"`
}
func newLagunaImportTransform(rawConfig json.RawMessage) (quantizePolicy, error) {
var cfg lagunaConfig
if len(rawConfig) > 0 {
if err := json.Unmarshal(rawConfig, &cfg); err != nil {
return nil, fmt.Errorf("laguna: parse config.json: %w", err)
}
}
denseLayers := make(map[int]bool)
for i, typ := range cfg.MLPLayerTypes {
if typ == "dense" {
denseLayers[i] = true
}
}
for _, layer := range cfg.MLPOnlyLayers {
denseLayers[layer] = true
}
if len(denseLayers) == 0 {
denseLayers[0] = true
}
numLayers := cfg.NumHiddenLayers
if numLayers == 0 {
numLayers = len(cfg.MLPLayerTypes)
}
if numLayers == 0 {
numLayers = 40
}
return lagunaImportTransform{
denseMLPLayers: denseLayers,
numLayers: numLayers,
}, nil
}
func (t lagunaImportTransform) quantizationType(name string, shape []int32, quantize string) string {
base := normalizeQuantType(quantize)
if !lagunaFPQuant(base) {
return GetTensorQuantization(name, shape, quantize)
}
switch {
case isEmbedTokensWeight(name) || strings.HasSuffix(name, "lm_head.weight"):
// Laguna has separate embedding and output weights. Both are large,
// quality-sensitive tensors, so keep them at 8-bit for FP quants.
return promoteEmbedding(shape, base)
case strings.HasSuffix(name, ".mlp.gate.weight"):
return ""
case base == "mxfp8" && lagunaAttentionProjection(name):
return ""
case lagunaAttentionProjection(name):
return lagunaQuantizationType(name, shape, base)
case lagunaDenseMLPProjection(name) && t.denseMLPLayers[layerIndex(name)]:
return lagunaQuantizationType(name, shape, base)
case base == "mxfp8" && lagunaRoutedExpertDownProjection(name):
if lagunaPromoteExpertDown(layerIndex(name), t.numLayers) {
return ""
}
return lagunaQuantizationType(name, shape, base)
case lagunaSharedExpertDownProjection(name):
return lagunaSensitiveType(lagunaPromoteExpertDown(layerIndex(name), t.numLayers), name, shape, base)
case lagunaSharedExpertProjection(name):
return lagunaQuantizationType(name, shape, base)
case lagunaRoutedExpertProjection(name):
return lagunaQuantizationType(name, shape, base)
default:
return ""
}
}
func lagunaFPQuant(quantize string) bool {
return quantize == "nvfp4" || quantize == "mxfp4" || quantize == "mxfp8"
}
func lagunaAttentionProjection(name string) bool {
return strings.Contains(name, ".self_attn.q_proj.weight") ||
strings.Contains(name, ".self_attn.k_proj.weight") ||
strings.Contains(name, ".self_attn.v_proj.weight") ||
strings.Contains(name, ".self_attn.o_proj.weight") ||
strings.Contains(name, ".self_attn.g_proj.weight")
}
func lagunaDenseMLPProjection(name string) bool {
return strings.Contains(name, ".mlp.gate_proj.weight") ||
strings.Contains(name, ".mlp.up_proj.weight") ||
strings.Contains(name, ".mlp.down_proj.weight")
}
func lagunaRoutedExpertProjection(name string) bool {
if !lagunaMLPProjectionWeight(name) {
return false
}
return strings.Contains(name, ".mlp.experts.")
}
func lagunaRoutedExpertDownProjection(name string) bool {
return strings.Contains(name, ".mlp.experts.") && strings.HasSuffix(name, ".down_proj.weight")
}
func lagunaSharedExpertProjection(name string) bool {
if !lagunaMLPProjectionWeight(name) {
return false
}
return strings.Contains(name, ".mlp.shared_expert.")
}
func lagunaSharedExpertDownProjection(name string) bool {
return strings.Contains(name, ".mlp.shared_expert.down_proj.weight")
}
// Laguna XS 2 and 2.1 are sensitive to fully quantizing expert down
// projections. Keep the same cadence for both: use higher precision on the
// input-side layers, final layers, and a sparse cadence early in the residual
// stream. For 4-bit fp quants that higher precision is mxfp8. For mxfp8, the
// shared expert down projections stay at source precision because the tensor
// class is small; routed expert down projections use the cadence to avoid
// pushing the model too close to bf16 size.
func lagunaPromoteExpertDown(layerIdx, numLayers int) bool {
return useMoreBitsWithMiddleEnd(layerIdx, numLayers, numLayers/2-4)
}
func lagunaMLPProjectionWeight(name string) bool {
return strings.HasSuffix(name, ".gate_proj.weight") ||
strings.HasSuffix(name, ".up_proj.weight") ||
strings.HasSuffix(name, ".down_proj.weight")
}
func lagunaQuantizationType(name string, shape []int32, quantize string) string {
q := GetTensorQuantization(name, shape, quantize)
// Laguna's architecture policy decides which sensitive tensors to
// promote. Undo the generic policy's blanket 4-to-8-bit promotion here.
if q != quantize && q == eightBit(quantize) {
return quantize
}
return q
}
func lagunaSensitiveType(promote bool, name string, shape []int32, quantize string) string {
if quantize == "mxfp8" {
return ""
}
if promote {
return GetTensorQuantization(name, shape, quantize)
}
return lagunaQuantizationType(name, shape, quantize)
}