github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-05 23:53:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #12717] Consolidate embeddings truncation #8438

New Issue
Closed
opened 2026-04-12 21:07:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 21:07:07 -05:00
Owner
Copy Link

Originally created by @jmorganca on GitHub (Oct 21, 2025).
Original GitHub issue: https://github.com/ollama/ollama/issues/12717

Originally assigned to: @npardal on GitHub.

What is the issue?

Currently, when truncate is provided to the /api/embed endpoint, truncation happens in two locations:

  1. The /api/embed handler in server: https://github.com/ollama/ollama/blob/main/server/routes.go#L676
  2. In the Ollama and Llama runners

We should consolidate on 2, which would clean up a bunch of code in the EmbedHandler function.

This would entail a few steps:

  1. Pass the truncate value through to the runner
  2. Return the token usage from the runner back to the server handler
  3. Ensure context window errors are propagated from the runner back to the server handler

Relevant log output

OS

No response

GPU

No response

CPU

No response

Ollama version

No response

Originally created by @jmorganca on GitHub (Oct 21, 2025). Original GitHub issue: https://github.com/ollama/ollama/issues/12717 Originally assigned to: @npardal on GitHub. ### What is the issue? Currently, when `truncate` is provided to the `/api/embed` endpoint, truncation happens in two locations: 1. The `/api/embed` handler in `server`: https://github.com/ollama/ollama/blob/main/server/routes.go#L676 2. In the [Ollama](https://github.com/ollama/ollama/blob/main/runner/ollamarunner/runner.go#L133) and [Llama](https://github.com/ollama/ollama/blob/main/runner/llamarunner/runner.go#L127) runners We should consolidate on 2, which would clean up a bunch of code in the `EmbedHandler` function. This would entail a few steps: 1. Pass the `truncate` value through to the runner 2. Return the token usage from the runner back to the server handler 3. Ensure context window errors are propagated from the runner back to the server handler ### Relevant log output ```shell ``` ### OS _No response_ ### GPU _No response_ ### CPU _No response_ ### Ollama version _No response_
GiteaMirror added the bug label 2026-04-12 21:07:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#8438
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?