github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15960] Warn when image files are not found #77668

New Issue
Open
opened 2026-05-05 10:20:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 10:20:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15960
Author: @ankit-songara
Created: 5/4/2026
Status: 🔄 Open

Base: main ← Head: fix/image-path-warning

📝 Commits (1)

  • 810c442 fix: warn when image files are not found

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 cmd/interactive.go (+2 -0)

📄 Description

Fixes #10333

Problem

When dragging image files into the CLI with paths containing special characters or escaped sequences, the normalized path might not match the actual file location. Ollama silently skips these files without any feedback, leaving users confused.

Solution

Add warning message that shows:- Original path from user input- Normalized path that was attempted

This helps users debug path issues and understand why their images weren't included.

Changes

  • Modified extractFileData() in cmd/interactive.go- When os.ErrNotExist, print warning instead of silent continue

Testing

Drag images with escaped paths (spaces, special chars) and verify warning appears in stderr

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15960 **Author:** [@ankit-songara](https://github.com/ankit-songara) **Created:** 5/4/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/image-path-warning` --- ### 📝 Commits (1) - [`810c442`](https://github.com/ollama/ollama/commit/810c442a03f9ac9de7d9f15cd1b345ff1b191324) fix: warn when image files are not found ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/interactive.go` (+2 -0) </details> ### 📄 Description Fixes #10333 ## Problem When dragging image files into the CLI with paths containing special characters or escaped sequences, the normalized path might not match the actual file location. Ollama silently skips these files without any feedback, leaving users confused. ## Solution Add warning message that shows:- Original path from user input- Normalized path that was attempted This helps users debug path issues and understand why their images weren't included. ## Changes - Modified extractFileData() in cmd/interactive.go- When os.ErrNotExist, print warning instead of silent continue ## Testing Drag images with escaped paths (spaces, special chars) and verify warning appears in stderr --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 10:20:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77668
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?