github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-07-15 20:54:54 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #15920] launch: repair missing editor config before launch #77653

New Issue
Open
opened 2026-05-05 10:19:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 10:19:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15920
Author: @hoyyeva
Created: 5/1/2026
Status: 🔄 Open

Base: main ← Head: hoyyeva/editor-config-repair

📝 Commits (4)

  • 355866c wip
  • e69cac2 launch: repair missing editor config before launch
  • 52fb0bf launch: repair missing editor config from saved state
  • 79a9e95 address comment

📊 Changes

10 files changed (+251 additions, -40 deletions)

View changed files

📝 cmd/launch/cline.go (+16 -0)
📝 cmd/launch/cline_test.go (+18 -1)
📝 cmd/launch/droid_test.go (+10 -0)
📝 cmd/launch/launch.go (+23 -1)
📝 cmd/launch/launch_test.go (+104 -10)
📝 cmd/launch/opencode.go (+1 -1)
📝 cmd/launch/opencode_test.go (+38 -6)
📝 cmd/launch/pi.go (+6 -8)
📝 cmd/launch/pi_test.go (+33 -11)
📝 cmd/launch/vscode_test.go (+2 -2)

📄 Description

Summary

Repairs missing or out-of-sync editor-managed config before launch for integrations that use the shared editor launch path.

What changed

  • simplifies the shared repair check in the editor launch flow
  • keeps missing-config detection inside each integration’s Paths() implementation
  • rewrites editor-managed config before launch when:
    • the integration reports no managed config path(s)
    • the integration-reported model list differs from the launcher-saved model list

Why

This keeps the shared launch logic simpler while preserving per-integration control over what counts as a present config file.

Integrations covered

This change applies to editor-style integrations that use the shared Editor launch path:

  • cline
  • droid
  • openclaw
  • opencode
  • pi
  • vscode

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15920 **Author:** [@hoyyeva](https://github.com/hoyyeva) **Created:** 5/1/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `hoyyeva/editor-config-repair` --- ### 📝 Commits (4) - [`355866c`](https://github.com/ollama/ollama/commit/355866cb24337ff7a07bebcd94b2cfe62add951d) wip - [`e69cac2`](https://github.com/ollama/ollama/commit/e69cac2ce3fd72561dab7c328abf647af9f5ae56) launch: repair missing editor config before launch - [`52fb0bf`](https://github.com/ollama/ollama/commit/52fb0bf2e38d5dc2e1294bb8e77c625115c8075d) launch: repair missing editor config from saved state - [`79a9e95`](https://github.com/ollama/ollama/commit/79a9e959ad97c0372fd2d3443f734a9350d21132) address comment ### 📊 Changes **10 files changed** (+251 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `cmd/launch/cline.go` (+16 -0) 📝 `cmd/launch/cline_test.go` (+18 -1) 📝 `cmd/launch/droid_test.go` (+10 -0) 📝 `cmd/launch/launch.go` (+23 -1) 📝 `cmd/launch/launch_test.go` (+104 -10) 📝 `cmd/launch/opencode.go` (+1 -1) 📝 `cmd/launch/opencode_test.go` (+38 -6) 📝 `cmd/launch/pi.go` (+6 -8) 📝 `cmd/launch/pi_test.go` (+33 -11) 📝 `cmd/launch/vscode_test.go` (+2 -2) </details> ### 📄 Description ## Summary Repairs missing or out-of-sync editor-managed config before launch for integrations that use the shared editor launch path. ## What changed - simplifies the shared repair check in the editor launch flow - keeps missing-config detection inside each integration’s `Paths()` implementation - rewrites editor-managed config before launch when: - the integration reports no managed config path(s) - the integration-reported model list differs from the launcher-saved model list ## Why This keeps the shared launch logic simpler while preserving per-integration control over what counts as a present config file. ## Integrations covered This change applies to editor-style integrations that use the shared `Editor` launch path: - `cline` - `droid` - `openclaw` - `opencode` - `pi` - `vscode` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 10:19:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?