github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-05 23:53:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15904] [MERGED] go: bump to 1.26 #77646

New Issue
Closed
opened 2026-05-05 10:19:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 10:19:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15904
Author: @ParthSareen
Created: 4/30/2026
Status: ✅ Merged
Merged: 5/4/2026
Merged by: @ParthSareen

Base: main ← Head: parth/bump-go-version

📝 Commits (3)

  • 538242c go: bump to 1.26
  • b29cae4 docs: drop synctest note
  • c931ee6 x/imagegen/transfer: drop flaky Windows tests

📊 Changes

6 files changed (+3 additions, -173 deletions)

View changed files

📝 docs/development.md (+0 -29)
📝 go.mod (+1 -1)
📝 server/internal/internal/backoff/backoff_synctest_test.go (+1 -3)
📝 server/internal/internal/backoff/backoff_test.go (+0 -15)
📝 server/internal/internal/syncs/line_test.go (+1 -3)
📝 x/imagegen/transfer/transfer_test.go (+0 -122)

📄 Description

Summary

  • Bump go.mod from 1.24.1 to 1.26.0. Dockerfile and CI workflows already derive the version from go.mod, so no other infra changes needed.
  • Migrate testing/synctest tests to the stable API: synctest.Run is removed in Go 1.26, replaced by synctest.Test(t, func(t *testing.T) { ... }). Drop the //go:build goexperiment.synctest tags so the tests actually run in CI (CI never set the experiment, so they were dead).
  • Remove BenchmarkLoop in server/internal/internal/backoff — stable testing/synctest has no testing.B support.
  • Drop the now-stale GOEXPERIMENT=synctest notes from docs/development.md.

Test plan

  • go build ./...
  • go test ./server/internal/internal/backoff/... ./server/internal/internal/syncs/...
  • CI green

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15904 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 4/30/2026 **Status:** ✅ Merged **Merged:** 5/4/2026 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth/bump-go-version` --- ### 📝 Commits (3) - [`538242c`](https://github.com/ollama/ollama/commit/538242c261d2e4ff8daa0fb79abd63fbcfd663aa) go: bump to 1.26 - [`b29cae4`](https://github.com/ollama/ollama/commit/b29cae435d51ba2f736f696c018218ad993f5226) docs: drop synctest note - [`c931ee6`](https://github.com/ollama/ollama/commit/c931ee6b24a1e48af3a258db8bc7bf15c15b2379) x/imagegen/transfer: drop flaky Windows tests ### 📊 Changes **6 files changed** (+3 additions, -173 deletions) <details> <summary>View changed files</summary> 📝 `docs/development.md` (+0 -29) 📝 `go.mod` (+1 -1) 📝 `server/internal/internal/backoff/backoff_synctest_test.go` (+1 -3) 📝 `server/internal/internal/backoff/backoff_test.go` (+0 -15) 📝 `server/internal/internal/syncs/line_test.go` (+1 -3) 📝 `x/imagegen/transfer/transfer_test.go` (+0 -122) </details> ### 📄 Description ## Summary - Bump `go.mod` from `1.24.1` to `1.26.0`. Dockerfile and CI workflows already derive the version from `go.mod`, so no other infra changes needed. - Migrate `testing/synctest` tests to the stable API: `synctest.Run` is removed in Go 1.26, replaced by `synctest.Test(t, func(t *testing.T) { ... })`. Drop the `//go:build goexperiment.synctest` tags so the tests actually run in CI (CI never set the experiment, so they were dead). - Remove `BenchmarkLoop` in `server/internal/internal/backoff` — stable `testing/synctest` has no `testing.B` support. - Drop the now-stale `GOEXPERIMENT=synctest` notes from `docs/development.md`. ## Test plan - [x] `go build ./...` - [x] `go test ./server/internal/internal/backoff/... ./server/internal/internal/syncs/...` - [x] CI green --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 10:19:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77646
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?