github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15852] cmd: add regression test for escaped iCloud image paths #77623

New Issue
Open
opened 2026-05-05 10:17:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 10:17:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15852
Author: @Shiyao-Huang
Created: 4/28/2026
Status: 🔄 Open

Base: main ← Head: fix/issue-10333-regression-test

📝 Commits (1)

  • d7933c4 cmd: add regression test for escaped iCloud image paths

📊 Changes

1 file changed (+37 additions, -0 deletions)

View changed files

📝 cmd/interactive_test.go (+37 -0)

📄 Description

Summary

  • add a regression test for escaped iCloud image paths in CLI multimodal input parsing
  • cover the exact path shape from #10333 (Mobile\ Documents, com\~apple\~CloudDocs, @2x.png)

Why

Issue #10333 reports that a dragged image path from iCloud Drive was treated as plain text instead of being attached as an image.

When I reproduced the reported path format on the current main branch, the behavior was already correct, which suggests the bug affected older versions (the issue reports 0.6.5) and was fixed without a dedicated regression test. This change locks that behavior in with coverage.

Validation

go test ./cmd -run 'TestExtractFileData(RecognizesEscapedICloudImagePath|RemovesQuotedFilepath|WAV)$'
go test ./cmd

Risk

Low — test-only change, no production logic changes.

Related

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15852 **Author:** [@Shiyao-Huang](https://github.com/Shiyao-Huang) **Created:** 4/28/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/issue-10333-regression-test` --- ### 📝 Commits (1) - [`d7933c4`](https://github.com/ollama/ollama/commit/d7933c44226266ebdf54bc08dff5299704d289e2) cmd: add regression test for escaped iCloud image paths ### 📊 Changes **1 file changed** (+37 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/interactive_test.go` (+37 -0) </details> ### 📄 Description ## Summary - add a regression test for escaped iCloud image paths in CLI multimodal input parsing - cover the exact path shape from #10333 (`Mobile\ Documents`, `com\~apple\~CloudDocs`, `@2x.png`) ## Why Issue #10333 reports that a dragged image path from iCloud Drive was treated as plain text instead of being attached as an image. When I reproduced the reported path format on the current `main` branch, the behavior was already correct, which suggests the bug affected older versions (the issue reports 0.6.5) and was fixed without a dedicated regression test. This change locks that behavior in with coverage. ## Validation ```bash go test ./cmd -run 'TestExtractFileData(RecognizesEscapedICloudImagePath|RemovesQuotedFilepath|WAV)$' go test ./cmd ``` ## Risk Low — test-only change, no production logic changes. ## Related - Closes #10333 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 10:17:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77623
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?