github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15682] llm: report runner status when Wait returns nil #77553

New Issue
Open
opened 2026-05-05 10:13:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 10:13:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15682
Author: @mverrilli
Created: 4/18/2026
Status: 🔄 Open

Base: main ← Head: fix/issue-15143-runner-nil-error-format

📝 Commits (1)

  • b9d3056 llm: report runner status when Wait returns nil

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 llm/server.go (+8 -1)

📄 Description

Noticed in #15143: on the runner-has-exited path, WaitUntilRunning wraps s.doneErr with %w. When cmd.Wait returns nil the reaper stores nil there, so users see %!w(<nil>) in place of any real diagnostic.

Fall back to status.LastErrMsg using the same pattern used elsewhere in this file when a runner has exited. The non-nil path is unchanged so errors.Is / errors.As still work.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15682 **Author:** [@mverrilli](https://github.com/mverrilli) **Created:** 4/18/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/issue-15143-runner-nil-error-format` --- ### 📝 Commits (1) - [`b9d3056`](https://github.com/ollama/ollama/commit/b9d30561b6d573dd379d0dbcb3279d66eb0505b3) llm: report runner status when Wait returns nil ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `llm/server.go` (+8 -1) </details> ### 📄 Description Noticed in #15143: on the runner-has-exited path, `WaitUntilRunning` wraps `s.doneErr` with `%w`. When `cmd.Wait` returns nil the reaper stores nil there, so users see `%!w(<nil>)` in place of any real diagnostic. Fall back to `status.LastErrMsg` using the same pattern used elsewhere in this file when a runner has exited. The non-nil path is unchanged so `errors.Is` / `errors.As` still work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 10:13:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77553
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?