github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15678] [MERGED] server: apply format when think=false with thinking-capable parser #77552

New Issue
Closed
opened 2026-05-05 10:13:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 10:13:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15678
Author: @ParthSareen
Created: 4/18/2026
Status: ✅ Merged
Merged: 4/21/2026
Merged by: @ParthSareen

Base: main ← Head: parth/fix-format-think-false

📝 Commits (3)

  • 815f043 server: apply format when think=false with thinking-capable parser
  • aa1e197 server: scope think=false format gating to gemma4
  • 62a8798 Update comment

📊 Changes

2 files changed (+130 additions, -1 deletions)

View changed files

📝 server/routes.go (+4 -1)
📝 server/routes_generate_test.go (+126 -0)

📄 Description

Fixes #15260.

Adding a small patch to allow gemma4 to be constrained with thinking turned off. The cases for other models may vary, so a long term solution must be added on a parser level. Small PR to unblock users.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15678 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 4/18/2026 **Status:** ✅ Merged **Merged:** 4/21/2026 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth/fix-format-think-false` --- ### 📝 Commits (3) - [`815f043`](https://github.com/ollama/ollama/commit/815f043695e9725d7be9c5c4d7ec79633d0f55d1) server: apply format when think=false with thinking-capable parser - [`aa1e197`](https://github.com/ollama/ollama/commit/aa1e1972c87111a8e316ce05c8bf87763c48a213) server: scope think=false format gating to gemma4 - [`62a8798`](https://github.com/ollama/ollama/commit/62a8798a49388dbf4db21ba8d80221c4282174eb) Update comment ### 📊 Changes **2 files changed** (+130 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+4 -1) 📝 `server/routes_generate_test.go` (+126 -0) </details> ### 📄 Description Fixes #15260. Adding a small patch to allow gemma4 to be constrained with thinking turned off. The cases for other models may vary, so a long term solution must be added on a parser level. Small PR to unblock users. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 10:13:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?