github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14781] x/agent: fix false positive deny pattern matching in heredocs #77127

New Issue
Open
opened 2026-05-05 09:49:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 09:49:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14781
Author: @moktamd
Created: 3/11/2026
Status: 🔄 Open

Base: main ← Head: fix/agent-deny-pattern-false-positives

📝 Commits (2)

  • dedf0de x/agent: fix false positive deny pattern matching in heredocs
  • 341d256 address review: add $() and backtick to command prefixes, expand tests

📊 Changes

2 files changed (+184 additions, -7 deletions)

View changed files

📝 x/agent/approval.go (+130 -6)
📝 x/agent/approval_test.go (+54 -1)

📄 Description

The IsDenied function uses naive substring matching against the full command string, which causes false positives when heredoc bodies contain substrings matching deny patterns (e.g. su matching inside words like "result" or "ensure").

Two changes to fix this:

  • Strip heredoc bodies before checking deny patterns
  • Require command-like patterns (su, nc, sudo, etc.) to appear at a shell command position rather than anywhere in the string

Fixes #14766

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14781 **Author:** [@moktamd](https://github.com/moktamd) **Created:** 3/11/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/agent-deny-pattern-false-positives` --- ### 📝 Commits (2) - [`dedf0de`](https://github.com/ollama/ollama/commit/dedf0de9831b141f9f1c7b4ca0d3f028035c584f) x/agent: fix false positive deny pattern matching in heredocs - [`341d256`](https://github.com/ollama/ollama/commit/341d2562cb00b661eeabfdcd5f92e2888a599286) address review: add $() and backtick to command prefixes, expand tests ### 📊 Changes **2 files changed** (+184 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `x/agent/approval.go` (+130 -6) 📝 `x/agent/approval_test.go` (+54 -1) </details> ### 📄 Description The `IsDenied` function uses naive substring matching against the full command string, which causes false positives when heredoc bodies contain substrings matching deny patterns (e.g. `su ` matching inside words like "result" or "ensure"). Two changes to fix this: - Strip heredoc bodies before checking deny patterns - Require command-like patterns (`su`, `nc`, `sudo`, etc.) to appear at a shell command position rather than anywhere in the string Fixes #14766 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 09:49:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77127
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?