github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14670] progress: suppress ANSI escape sequences when not connected to a terminal #77071

New Issue
Open
opened 2026-05-05 09:47:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 09:47:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14670
Author: @majiayu000
Created: 3/6/2026
Status: 🔄 Open

Base: main ← Head: fix/issue-14571-suppress-control-chars

📝 Commits (1)

  • 860046d progress: suppress ANSI escape sequences when not connected to a terminal

📊 Changes

2 files changed (+67 additions, -1 deletions)

View changed files

📝 progress/progress.go (+13 -1)
➕ progress/progress_test.go (+54 -0)

📄 Description

Summary

Suppress ANSI escape sequences in the progress package when stderr is not connected to a terminal. This prevents control character garbage when piping ollama run output.

Fixes #14571

Changes

  • Add TTY detection in NewProgress() via term.IsTerminal() (already a dependency)
  • Skip render() entirely when not a TTY
  • Skip ANSI output in Stop() and StopAndClear() when not a TTY

Test plan

  • Added progress/progress_test.go with 3 tests verifying non-TTY behavior
  • go test ./progress/ -v passes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14670 **Author:** [@majiayu000](https://github.com/majiayu000) **Created:** 3/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/issue-14571-suppress-control-chars` --- ### 📝 Commits (1) - [`860046d`](https://github.com/ollama/ollama/commit/860046d635220af75f45ba2f52c9eee9d84ca05a) progress: suppress ANSI escape sequences when not connected to a terminal ### 📊 Changes **2 files changed** (+67 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `progress/progress.go` (+13 -1) ➕ `progress/progress_test.go` (+54 -0) </details> ### 📄 Description ## Summary Suppress ANSI escape sequences in the `progress` package when stderr is not connected to a terminal. This prevents control character garbage when piping `ollama run` output. Fixes #14571 ## Changes - Add TTY detection in `NewProgress()` via `term.IsTerminal()` (already a dependency) - Skip `render()` entirely when not a TTY - Skip ANSI output in `Stop()` and `StopAndClear()` when not a TTY ## Test plan - Added `progress/progress_test.go` with 3 tests verifying non-TTY behavior - `go test ./progress/ -v` passes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 09:47:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#77071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?