github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14404] [CLOSED] fix: return defaultValue on parse error in BoolWithDefault #76953

New Issue
Closed
opened 2026-05-05 09:41:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 09:41:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14404
Author: @tysoncung
Created: 2/25/2026
Status: ❌ Closed

Base: main ← Head: fix/bool-with-default-fallback

📝 Commits (1)

  • 1d5a65a fix: return defaultValue on parse error in BoolWithDefault

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 envconfig/config.go (+1 -1)

📄 Description

Fixes #14389

BoolWithDefault returns true when strconv.ParseBool fails to parse the environment variable value, instead of returning defaultValue. This causes boolean feature flags to be silently enabled when a user sets an env var to a common-but-invalid string like "yes", "on", or "enabled".

The fix changes the error fallback from return true to return defaultValue, which is the intended behavior.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14404 **Author:** [@tysoncung](https://github.com/tysoncung) **Created:** 2/25/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/bool-with-default-fallback` --- ### 📝 Commits (1) - [`1d5a65a`](https://github.com/ollama/ollama/commit/1d5a65aac976a4bead523997758e125edfd41eb8) fix: return defaultValue on parse error in BoolWithDefault ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `envconfig/config.go` (+1 -1) </details> ### 📄 Description Fixes #14389 `BoolWithDefault` returns `true` when `strconv.ParseBool` fails to parse the environment variable value, instead of returning `defaultValue`. This causes boolean feature flags to be silently enabled when a user sets an env var to a common-but-invalid string like `"yes"`, `"on"`, or `"enabled"`. The fix changes the error fallback from `return true` to `return defaultValue`, which is the intended behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 09:41:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#76953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?