github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 17:49:24 -05:00
Code Issues 14.5k Packages Projects Releases 122 Wiki Activity

[PR #13453] [MERGED] model: default gemma 3 rope scale to 1.0 #76510

New Issue
Closed
opened 2026-05-05 09:06:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 09:06:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13453
Author: @jmorganca
Created: 12/13/2025
Status: ✅ Merged
Merged: 12/13/2025
Merged by: @jmorganca

Base: main ← Head: jmorganca/gemma3-default-rope-scale-1

📝 Commits (2)

  • c49e9f8 model: default gemma 3 rope scale to 1.0
  • 79e98b2 Fix detection of gemma3 1b to disable logit softcapping

📊 Changes

1 file changed (+34 additions, -26 deletions)

View changed files

📝 model/models/gemma3/model_text.go (+34 -26)

📄 Description

Default rope scale to 1.0, as Gemma3 1B does not set this value and assumes a default of 1.0. For other sizes, rope.factor should be set to 8.0. Also fixes a bug in Gemma3 1B where we apply logit softcapping (the previous check to set it to 0.0 was not effective)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13453 **Author:** [@jmorganca](https://github.com/jmorganca) **Created:** 12/13/2025 **Status:** ✅ Merged **Merged:** 12/13/2025 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `jmorganca/gemma3-default-rope-scale-1` --- ### 📝 Commits (2) - [`c49e9f8`](https://github.com/ollama/ollama/commit/c49e9f88b2f57c4916546d0b10e535737ae8e37b) model: default gemma 3 rope scale to 1.0 - [`79e98b2`](https://github.com/ollama/ollama/commit/79e98b2a9bd2d4d19910ead15983d7c83b1b8d58) Fix detection of gemma3 1b to disable logit softcapping ### 📊 Changes **1 file changed** (+34 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `model/models/gemma3/model_text.go` (+34 -26) </details> ### 📄 Description Default rope scale to 1.0, as Gemma3 1B does not set this value and assumes a default of 1.0. For other sizes, `rope.factor` should be set to 8.0. Also fixes a bug in Gemma3 1B where we apply logit softcapping (the previous check to set it to 0.0 was not effective) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 09:06:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#76510
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?