github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #13352] cmd: preserve relative paths for files and adapters in CreateHandler #76469

New Issue
Open
opened 2026-05-05 09:02:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 09:02:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13352
Author: @unbiasedcodex
Created: 12/6/2025
Status: 🔄 Open

Base: main ← Head: fix/windows-path-handling

📝 Commits (1)

  • c98848f cmd: preserve relative paths for files and adapters in CreateHandler

📊 Changes

1 file changed (+2 additions, -6 deletions)

View changed files

📝 cmd/cmd.go (+2 -6)

📄 Description

Summary:

  • Fixes file path handling in CreateHandler that was incorrectly using filepath.Base()
  • This caused files in subdirectories with the same name to overwrite each other in the map
  • Removes the TODO comments that documented this known issue

Problem:

When creating a model with files in different subdirectories that have the same filename:

MODEL models/lora/adapter.safetensors
MODEL models/lora2/adapter.safetensors

The second entry would overwrite the first because filepath.Base() stripped the directory path, leaving only adapter.safetensors as the key for both.

Solution:

Preserve the full relative path instead of extracting just the filename.
The server already expects and validates relative paths via fs.ValidPath().

Fixes #10333

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13352 **Author:** [@unbiasedcodex](https://github.com/unbiasedcodex) **Created:** 12/6/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/windows-path-handling` --- ### 📝 Commits (1) - [`c98848f`](https://github.com/ollama/ollama/commit/c98848f1f82c7d1d144fdf1970e34268ca337823) cmd: preserve relative paths for files and adapters in CreateHandler ### 📊 Changes **1 file changed** (+2 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd.go` (+2 -6) </details> ### 📄 Description Summary: - Fixes file path handling in `CreateHandler` that was incorrectly using `filepath.Base()` - This caused files in subdirectories with the same name to overwrite each other in the map - Removes the TODO comments that documented this known issue Problem: When creating a model with files in different subdirectories that have the same filename: MODEL models/lora/adapter.safetensors MODEL models/lora2/adapter.safetensors The second entry would overwrite the first because `filepath.Base()` stripped the directory path, leaving only `adapter.safetensors` as the key for both. Solution: Preserve the full relative path instead of extracting just the filename. The server already expects and validates relative paths via `fs.ValidPath()`. Fixes #10333 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 09:02:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#76469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?