github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-23 14:13:13 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #12393] [MERGED] harmony: don't sanitize built-ins #76103

New Issue
Closed
opened 2026-05-05 08:33:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 08:33:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12393
Author: @drifkin
Created: 9/24/2025
Status: ✅ Merged
Merged: 9/24/2025
Merged by: @drifkin

Base: main ← Head: drifkin/fix-built-ins

📝 Commits (1)

  • fd88cd7 harmony: don't sanitize built-ins

📊 Changes

2 files changed (+5 additions, -0 deletions)

View changed files

📝 harmony/harmonyparser.go (+4 -0)
📝 harmony/harmonyparser_test.go (+1 -0)

📄 Description

In #11910 we started sanitizing function names, but we accidentally were modifying built-ins like browser.open to browser_open. This was removing the special prompt rendering for built-ins, but this wasn't immediately apparent since the models seem to be reasonably good at remembering the built-ins even when presented with these slightly renamed version. This fix prevents built-ins from ever being renamed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12393 **Author:** [@drifkin](https://github.com/drifkin) **Created:** 9/24/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@drifkin](https://github.com/drifkin) **Base:** `main` ← **Head:** `drifkin/fix-built-ins` --- ### 📝 Commits (1) - [`fd88cd7`](https://github.com/ollama/ollama/commit/fd88cd7cb0966a26f41ec41bc012f2c4d725ab98) harmony: don't sanitize built-ins ### 📊 Changes **2 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `harmony/harmonyparser.go` (+4 -0) 📝 `harmony/harmonyparser_test.go` (+1 -0) </details> ### 📄 Description In #11910 we started sanitizing function names, but we accidentally were modifying built-ins like `browser.open` to `browser_open`. This was removing the special prompt rendering for built-ins, but this wasn't immediately apparent since the models seem to be reasonably good at remembering the built-ins even when presented with these slightly renamed version. This fix prevents built-ins from ever being renamed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 08:33:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#76103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?