github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #12302] parser: tidy up parameter/message parsing #76071

New Issue
Open
opened 2026-05-05 08:32:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 08:32:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12302
Author: @pdevine
Created: 9/16/2025
Status: 🔄 Open

Base: main ← Head: pdevine/parser-tidy

📝 Commits (1)

  • c10a40d parser: tidy up parameter/message parsing

📊 Changes

2 files changed (+98 additions, -46 deletions)

View changed files

📝 parser/parser.go (+81 -29)
📝 parser/parser_test.go (+17 -17)

📄 Description

This change addresses how parameters and messages are handled while parsing a Modelfile. Currently a MESSAGE command creates a string that looks like ": " which then has to be re-parsed, and PARAMETER ends up being the default data type which makes it difficult to add other multi-part commands.

This change introduces a Message and a Parameter type which properly handle properties such as the role and the name of the parameter.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12302 **Author:** [@pdevine](https://github.com/pdevine) **Created:** 9/16/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `pdevine/parser-tidy` --- ### 📝 Commits (1) - [`c10a40d`](https://github.com/ollama/ollama/commit/c10a40db995aa3847a5b29b051aed86d0d2aad00) parser: tidy up parameter/message parsing ### 📊 Changes **2 files changed** (+98 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `parser/parser.go` (+81 -29) 📝 `parser/parser_test.go` (+17 -17) </details> ### 📄 Description This change addresses how parameters and messages are handled while parsing a Modelfile. Currently a `MESSAGE` command creates a string that looks like "<role>: <message>" which then has to be re-parsed, and `PARAMETER` ends up being the default data type which makes it difficult to add other multi-part commands. This change introduces a Message and a Parameter type which properly handle properties such as the role and the name of the parameter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 08:32:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#76071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?