github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-07-15 12:48:05 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #10490] [MERGED] strip out thinking tags in message history for qwen3 & r1 #75550

New Issue
Closed
opened 2026-05-05 07:58:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 07:58:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10490
Author: @drifkin
Created: 4/30/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @drifkin

Base: main ← Head: drifkin/reasoning-tags

📝 Commits (2)

  • 1212afe strip out thinking tags in message history for qwen3 & r1
  • bc174a9 parse model names instead of hacky prefix check

📊 Changes

2 files changed (+148 additions, -0 deletions)

View changed files

📝 server/routes.go (+22 -0)
📝 server/routes_test.go (+126 -0)

📄 Description

This is in advance of "proper" support where we'll make reasoning configurable and we'll parse out thinking/reasoning tags and provide them to the caller. These models expect there to be no thinking tags in the message history, so this should improve quality

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10490 **Author:** [@drifkin](https://github.com/drifkin) **Created:** 4/30/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@drifkin](https://github.com/drifkin) **Base:** `main` ← **Head:** `drifkin/reasoning-tags` --- ### 📝 Commits (2) - [`1212afe`](https://github.com/ollama/ollama/commit/1212afeb9ec8247b997163d80e01ff0a285eaa1e) strip out thinking tags in message history for qwen3 & r1 - [`bc174a9`](https://github.com/ollama/ollama/commit/bc174a902b30ab6a4aeef0b7a8ae2ddf14328d28) parse model names instead of hacky prefix check ### 📊 Changes **2 files changed** (+148 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+22 -0) 📝 `server/routes_test.go` (+126 -0) </details> ### 📄 Description This is in advance of "proper" support where we'll make reasoning configurable and we'll parse out thinking/reasoning tags and provide them to the caller. These models expect there to be no thinking tags in the message history, so this should improve quality --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 07:58:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#75550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?