github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 00:51:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #9669] [MERGED] sample: fix sorting order and top_k #75327

New Issue
Closed
opened 2026-05-05 07:45:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 07:45:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/9669
Author: @ParthSareen
Created: 3/12/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @ParthSareen

Base: main ← Head: parth/sample-fix-sorting

📝 Commits (3)

  • db10a7d sample: use container/heap for top_k
  • 8b1ae03 sample: simplify top_k=0 sorting
  • f257f1f sample: do all sorting in topK

📊 Changes

3 files changed (+92 additions, -135 deletions)

View changed files

📝 sample/samplers.go (+2 -5)
📝 sample/transforms.go (+46 -105)
📝 sample/transforms_test.go (+44 -25)

📄 Description

  • the existing min heap implementation would fail for maintaining the correct sorting order - added container/heap implementation

  • partial sorting instead of counting sort

  • added tests to ensure floats were checked correctly

  • vibe check the logits and model

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/9669 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 3/12/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth/sample-fix-sorting` --- ### 📝 Commits (3) - [`db10a7d`](https://github.com/ollama/ollama/commit/db10a7da88118e3a4036bb1270d268e5644e46f8) sample: use container/heap for top_k - [`8b1ae03`](https://github.com/ollama/ollama/commit/8b1ae0330202a34c5bdcb8bbdf48da71e300a55a) sample: simplify top_k=0 sorting - [`f257f1f`](https://github.com/ollama/ollama/commit/f257f1fd04785c1ffe2e19826bc89b89a500adbc) sample: do all sorting in topK ### 📊 Changes **3 files changed** (+92 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `sample/samplers.go` (+2 -5) 📝 `sample/transforms.go` (+46 -105) 📝 `sample/transforms_test.go` (+44 -25) </details> ### 📄 Description - the existing min heap implementation would fail for maintaining the correct sorting order - added container/heap implementation - partial sorting instead of counting sort - added tests to ensure floats were checked correctly - [ ] vibe check the logits and model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 07:45:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#75327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?