[PR #8865] [MERGED] chore(format): rename test file from byte_test.go to bytes_test.go #75096

Closed
opened 2026-05-05 07:30:06 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8865
Author: @fyvri
Created: 2/6/2025
Status: Merged
Merged: 2/6/2025
Merged by: @BruceMacD

Base: mainHead: test/add-byte-format-test


📝 Commits (9)

  • 3e85b97 refactor(format/byte): simplify byte formatting logic
  • 053730d test: add tests for HumanBytes and HumanBytes2
  • 4bb88b1 Merge branch 'ollama:main' into test/add-byte-format-test
  • 0c713a7 Merge branch 'ollama:main' into test/add-byte-format-test
  • ea454cf Merge branch 'ollama:main' into test/add-byte-format-test
  • c2f023f Merge branch 'ollama:main' into test/add-byte-format-test
  • aa0ef75 Merge branch 'ollama:main' into test/add-byte-format-test
  • d041dff chore(format): rename test file from byte_test.go to bytes_test.go
  • c8ddba4 Merge branch 'ollama:main' into test/add-byte-format-test

📊 Changes

1 file changed (+0 additions, -0 deletions)

View changed files

📝 format/bytes_test.go (+0 -0)

📄 Description

📖 Purpose of the Change

This pull request renames the test file byte_test.go to bytes_test.go. The change aligns with naming conventions and improves clarity by ensuring that the file name accurately reflects its purpose.

🛠️ Why This Change Was Made

  • Consistency: The renamed file (bytes_test.go) better matches the plural naming convention commonly used in Go projects for files related to byte slices or operations.
  • Maintainability: Standardized naming reduces cognitive overhead and helps maintain a clean and organized codebase.

🚀 Impact of the Change

  • No functional changes have been introduced; this is purely a formatting improvement.
  • Existing tests and functionality remain unaffected, as the file's content has not been altered—only its name.

Let me know if there are any questions or further clarifications needed 🙌


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8865 **Author:** [@fyvri](https://github.com/fyvri) **Created:** 2/6/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `test/add-byte-format-test` --- ### 📝 Commits (9) - [`3e85b97`](https://github.com/ollama/ollama/commit/3e85b97ab32a872d6a8cebe11c3ea73cdcc57cd2) refactor(format/byte): simplify byte formatting logic - [`053730d`](https://github.com/ollama/ollama/commit/053730de60fcfeb6a50fc44b0930da00761683ac) test: add tests for HumanBytes and HumanBytes2 - [`4bb88b1`](https://github.com/ollama/ollama/commit/4bb88b1bc7f7f4adf89bbb5a900a3e3a6c47a0d1) Merge branch 'ollama:main' into test/add-byte-format-test - [`0c713a7`](https://github.com/ollama/ollama/commit/0c713a759e273fa72e88ab1b4c8a57b42526dbb1) Merge branch 'ollama:main' into test/add-byte-format-test - [`ea454cf`](https://github.com/ollama/ollama/commit/ea454cfddc99559f793f9016cfcb8420e3065fd7) Merge branch 'ollama:main' into test/add-byte-format-test - [`c2f023f`](https://github.com/ollama/ollama/commit/c2f023f4718e038e56e95a0ed87108472cd58e30) Merge branch 'ollama:main' into test/add-byte-format-test - [`aa0ef75`](https://github.com/ollama/ollama/commit/aa0ef75f14fe3e249acbc9849d31fca28be93926) Merge branch 'ollama:main' into test/add-byte-format-test - [`d041dff`](https://github.com/ollama/ollama/commit/d041dff10f38ea9063025666b7225903457fe27b) chore(format): rename test file from byte_test.go to bytes_test.go - [`c8ddba4`](https://github.com/ollama/ollama/commit/c8ddba4c5350795fa2b4c94301f20188d776ead2) Merge branch 'ollama:main' into test/add-byte-format-test ### 📊 Changes **1 file changed** (+0 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `format/bytes_test.go` (+0 -0) </details> ### 📄 Description ### 📖 Purpose of the Change This pull request renames the test file `byte_test.go` to `bytes_test.go`. The change aligns with naming conventions and improves clarity by ensuring that the file name accurately reflects its purpose. ## 🛠️ Why This Change Was Made - **Consistency**: The renamed file (`bytes_test.go`) better matches the plural naming convention commonly used in Go projects for files related to byte slices or operations. - **Maintainability**: Standardized naming reduces cognitive overhead and helps maintain a clean and organized codebase. ### 🚀 Impact of the Change - No functional changes have been introduced; this is purely a formatting improvement. - Existing tests and functionality remain unaffected, as the file's content has not been altered—only its name. --- Let me know if there are any questions or further clarifications needed 🙌 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 07:30:06 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#75096