[PR #8587] [MERGED] llm: update library lookup logic now that there is one runner #75023

Closed
opened 2026-05-05 07:22:20 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8587
Author: @jmorganca
Created: 1/26/2025
Status: Merged
Merged: 1/29/2025
Merged by: @jmorganca

Base: mxyng/next-buildHead: jmorganca/next-build-lookup


📝 Commits (10+)

📊 Changes

11 files changed (+150 additions, -358 deletions)

View changed files

📝 discover/amd_common.go (+4 -9)
📝 discover/amd_linux.go (+2 -4)
📝 discover/amd_windows.go (+3 -7)
📝 discover/gpu.go (+24 -46)
📝 discover/gpu_darwin.go (+0 -3)
discover/path.go (+53 -0)
📝 discover/types.go (+1 -2)
📝 envconfig/config.go (+0 -9)
📝 llm/server.go (+63 -74)
runners/common.go (+0 -195)
📝 server/routes.go (+0 -9)

📄 Description

This removes the runners package now that there is only a single runner executable built (the ollama binary itself!). It tries to minimize changes to discover and gpu where possible.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8587 **Author:** [@jmorganca](https://github.com/jmorganca) **Created:** 1/26/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `mxyng/next-build` ← **Head:** `jmorganca/next-build-lookup` --- ### 📝 Commits (10+) - [`e7e464e`](https://github.com/ollama/ollama/commit/e7e464e41dec6beae627de6c7b7289ac7d7d9ce0) llm: update library lookup logic now that there is one runner - [`c466425`](https://github.com/ollama/ollama/commit/c466425415e683b5b55875c47a298a2739aaa530) fix metal - [`57112f1`](https://github.com/ollama/ollama/commit/57112f1899e53e301f657a54c0eb8a722b6b5b1a) fix lookup - [`f729b6a`](https://github.com/ollama/ollama/commit/f729b6a91d347db19ebfd7a2838e9041f4b9166f) fix linter - [`598247a`](https://github.com/ollama/ollama/commit/598247a0834494a49a906b77531233aa2a98319a) better variable names - [`ab15917`](https://github.com/ollama/ollama/commit/ab15917c2e13054ef035dc111075591f8e24d763) silence -Wimplicit-function-declaration build warnings in ggml-cpu - [`9e38a36`](https://github.com/ollama/ollama/commit/9e38a36a7c2f88a02c9adcef6b4217e1e0f3751e) clean up unnecessary library paths - [`f2178d9`](https://github.com/ollama/ollama/commit/f2178d9d1bf6f6f7cea19140d6b3b5258d387eaa) add tests - [`08f14cc`](https://github.com/ollama/ollama/commit/08f14cc3e591fa89e9f73ecacfcbf2be388bebcf) fix linter - [`127dcbf`](https://github.com/ollama/ollama/commit/127dcbffff97f098ce4d485efccc38b3f078a3dd) simplify lib/ollama lookup ### 📊 Changes **11 files changed** (+150 additions, -358 deletions) <details> <summary>View changed files</summary> 📝 `discover/amd_common.go` (+4 -9) 📝 `discover/amd_linux.go` (+2 -4) 📝 `discover/amd_windows.go` (+3 -7) 📝 `discover/gpu.go` (+24 -46) 📝 `discover/gpu_darwin.go` (+0 -3) ➕ `discover/path.go` (+53 -0) 📝 `discover/types.go` (+1 -2) 📝 `envconfig/config.go` (+0 -9) 📝 `llm/server.go` (+63 -74) ➖ `runners/common.go` (+0 -195) 📝 `server/routes.go` (+0 -9) </details> ### 📄 Description This removes the `runners` package now that there is only a single runner executable built (the `ollama` binary itself!). It tries to minimize changes to `discover` and `gpu` where possible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 07:22:20 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#75023