github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #8123] [CLOSED] llm/grammar: introduce new grammar package #74928

New Issue
Closed
opened 2026-05-05 07:15:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 07:15:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8123
Author: @bmizerany
Created: 12/16/2024
Status: ❌ Closed

Base: main ← Head: bmizerany/grammers

📝 Commits (1)

  • 0de52bc grammar: introduce new grammar package

📊 Changes

5 files changed (+601 additions, -0 deletions)

View changed files

➕ grammar/bench_test.go (+22 -0)
➕ grammar/grammar.go (+219 -0)
➕ grammar/grammar_test.go (+92 -0)
➕ grammar/jsonschema/decode.go (+166 -0)
➕ grammar/jsonschema/decode_test.go (+102 -0)

📄 Description

This package provides a way to convert JSON schemas to equivalent EBNF. It is intended to be a replacement to llama.cpp's schema_to_grammar.

This is still an early version and does not yet support all JSON schema features. The to-do list includes:

  • minumum/maximum constraints on integer types
  • minLength/maxLength constraints on string types
  • defs and refs
  • performance improvements once we're happy with correctness and feature set.

NOTE: This also fixes outstanding issues caused by llama.cpp's schema_to_grammer; specifically that it does not maintain order of object keys in the schema when producing the resulting ebnf.

Owning our own converter allows us to have more control over bug prevention, speed, and accuracy of conversions, and removes yet another C dependency.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8123 **Author:** [@bmizerany](https://github.com/bmizerany) **Created:** 12/16/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bmizerany/grammers` --- ### 📝 Commits (1) - [`0de52bc`](https://github.com/ollama/ollama/commit/0de52bcde2e3227c4bb11ed8f794a71a8d8cb665) grammar: introduce new grammar package ### 📊 Changes **5 files changed** (+601 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `grammar/bench_test.go` (+22 -0) ➕ `grammar/grammar.go` (+219 -0) ➕ `grammar/grammar_test.go` (+92 -0) ➕ `grammar/jsonschema/decode.go` (+166 -0) ➕ `grammar/jsonschema/decode_test.go` (+102 -0) </details> ### 📄 Description This package provides a way to convert JSON schemas to equivalent EBNF. It is intended to be a replacement to llama.cpp's schema_to_grammar. This is still an early version and does not yet support all JSON schema features. The to-do list includes: - minumum/maximum constraints on integer types - minLength/maxLength constraints on string types - defs and refs - performance improvements once we're happy with correctness and feature set. NOTE: This also fixes outstanding issues caused by llama.cpp's schema_to_grammer; specifically that it does not maintain order of object keys in the schema when producing the resulting ebnf. Owning our own converter allows us to have more control over bug prevention, speed, and accuracy of conversions, and removes yet another C dependency. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 07:15:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#74928
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?