github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-05 23:53:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #4549] [MERGED] working on integration of multi-byte and multi-width runes #73817

New Issue
Closed
opened 2026-05-05 05:44:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 05:44:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/4549
Author: @joshyan1
Created: 5/21/2024
Status: ✅ Merged
Merged: 5/28/2024
Merged by: @joshyan1

Base: main ← Head: jyan/line-display

📝 Commits (10+)

  • 5061f44 integrated runewidth for display management - fixed cursor movement for mutli-width char
  • 7cdd0b1 updated input and deletion of multi-byte chars
  • 868112c fixed line history with some exceptions
  • d3c43f3 improved insert and add
  • 2731b78 fixed issues with moving across lines
  • ce681ef end of line extra space tracking'
  • d6e6b42 saved changes
  • 2841395 fixed end of line issues with empty spaces
  • fed24d8 worked some more
  • ed17a2c worked on end of line

📊 Changes

2 files changed (+305 additions, -86 deletions)

View changed files

📝 readline/buffer.go (+303 -84)
📝 readline/readline.go (+2 -2)

📄 Description

Fixed most issues touched on regarding multi-width runes.

Some notable issues still exist with a combination of insert and remove commands

Resolves: https://github.com/ollama/ollama/issues/3432 and resolves: https://github.com/ollama/ollama/issues/4156

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/4549 **Author:** [@joshyan1](https://github.com/joshyan1) **Created:** 5/21/2024 **Status:** ✅ Merged **Merged:** 5/28/2024 **Merged by:** [@joshyan1](https://github.com/joshyan1) **Base:** `main` ← **Head:** `jyan/line-display` --- ### 📝 Commits (10+) - [`5061f44`](https://github.com/ollama/ollama/commit/5061f445ab0cb7971091efe2508c6ca104778dcb) integrated runewidth for display management - fixed cursor movement for mutli-width char - [`7cdd0b1`](https://github.com/ollama/ollama/commit/7cdd0b13fa50343933d2f24537f57cb09ba3b3c6) updated input and deletion of multi-byte chars - [`868112c`](https://github.com/ollama/ollama/commit/868112cbc94fb564066dafa3b52839f7513fbec4) fixed line history with some exceptions - [`d3c43f3`](https://github.com/ollama/ollama/commit/d3c43f3405cc1bdfc2ae0fae6fbbca9ca092779f) improved insert and add - [`2731b78`](https://github.com/ollama/ollama/commit/2731b7854b9e72b371cc05a242855a6800d6423c) fixed issues with moving across lines - [`ce681ef`](https://github.com/ollama/ollama/commit/ce681efb0f90c7bb9aa15aa8d7eab6c0d798e395) end of line extra space tracking' - [`d6e6b42`](https://github.com/ollama/ollama/commit/d6e6b427a83d9c1dd732027150706be4e4455dc9) saved changes - [`2841395`](https://github.com/ollama/ollama/commit/2841395af93f1165a6ca67ba048c0502e93a4069) fixed end of line issues with empty spaces - [`fed24d8`](https://github.com/ollama/ollama/commit/fed24d84064807aed3dd6ad68147483c4b4e08c3) worked some more - [`ed17a2c`](https://github.com/ollama/ollama/commit/ed17a2c5713adb9afcc9f9194faa5dbb62868016) worked on end of line ### 📊 Changes **2 files changed** (+305 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `readline/buffer.go` (+303 -84) 📝 `readline/readline.go` (+2 -2) </details> ### 📄 Description Fixed most issues touched on regarding multi-width runes. Some notable issues still exist with a combination of `insert` and `remove` commands Resolves: https://github.com/ollama/ollama/issues/3432 and resolves: https://github.com/ollama/ollama/issues/4156 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 05:44:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#73817
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?