github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #3240] [CLOSED] do not prompt to move the CLI on install flow if already installed #73394

New Issue
Closed
opened 2026-05-05 05:12:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 05:12:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/3240
Author: @BruceMacD
Created: 3/19/2024
Status: ❌ Closed

Base: main ← Head: brucemacd/no-move-prompt-path

📝 Commits (4)

  • a467bd3 do not prompt the user to move to applications if ollama in path
  • 44c05ab skip to finish cli step if cli is already available
  • f15312c Update index.ts
  • 6e08c68 Update app.tsx

📊 Changes

3 files changed (+66 additions, -42 deletions)

View changed files

📝 macapp/src/app.tsx (+4 -1)
📝 macapp/src/index.ts (+39 -37)
📝 macapp/src/install.ts (+23 -4)

📄 Description

If Ollama is installed via brew or the user wishes to manage their path manually they will be prompted to install the CLI when opening the Ollama Mac app. This change attempts to check if Ollama is already set in the path, and if it is found the user is not prompted to link the executable to /usr/local/bin/ollama.

  • rather than checking if the symlink is set try to spawn common shells and see if ollama is available within them
  • make init async to allow for spawning shells
  • check for step param in installation UI to bypass the move to applications prompt
  • flatten init() conditional check to link ollama in /usr/local/bin/ollama

resolves #283
resolves #3186

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/3240 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 3/19/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `brucemacd/no-move-prompt-path` --- ### 📝 Commits (4) - [`a467bd3`](https://github.com/ollama/ollama/commit/a467bd3f6c964581b6fbd3a6e8d2353bfb7204cd) do not prompt the user to move to applications if ollama in path - [`44c05ab`](https://github.com/ollama/ollama/commit/44c05abd22b5b55af7a2d0129a9c73417ba66b0d) skip to finish cli step if cli is already available - [`f15312c`](https://github.com/ollama/ollama/commit/f15312c52bc54c852e9502cac64a1a9b3e8e2fd5) Update index.ts - [`6e08c68`](https://github.com/ollama/ollama/commit/6e08c68661414114586c0e85e390e5d56398188d) Update app.tsx ### 📊 Changes **3 files changed** (+66 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `macapp/src/app.tsx` (+4 -1) 📝 `macapp/src/index.ts` (+39 -37) 📝 `macapp/src/install.ts` (+23 -4) </details> ### 📄 Description If Ollama is installed via brew or the user wishes to manage their path manually they will be prompted to install the CLI when opening the Ollama Mac app. This change attempts to check if Ollama is already set in the path, and if it is found the user is not prompted to link the executable to `/usr/local/bin/ollama`. - rather than checking if the symlink is set try to spawn common shells and see if ollama is available within them - make init async to allow for spawning shells - check for `step` param in installation UI to bypass the `move to applications` prompt - flatten `init()` conditional check to link ollama in `/usr/local/bin/ollama` resolves #283 resolves #3186 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 05:12:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#73394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?