github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #2605] [CLOSED] Basic whitespace detection in JSON mode #73239

New Issue
Closed
opened 2026-05-05 04:58:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-05 04:58:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/2605
Author: @jmorganca
Created: 2/20/2024
Status: ❌ Closed

Base: main ← Head: whitespace-detection

📝 Commits (1)

  • aae31dc naive whitespace detection

📊 Changes

1 file changed (+19 additions, -0 deletions)

View changed files

📝 llm/dyn_ext_server.go (+19 -0)

📄 Description

This stops hanging from infinite whitespace generation by detecting 100 consecutive whitespace tokens and cancelling

Other ideas:

  • Repetition detection – detect the repetition of the same string over and over again
  • Only do this after detecting a full json object
  • Lower whitespace logit bias when using JSON mode (might affect outcome of the response)
  • Force user to specify JSON in the prompt (might be hard for folks to know this, this is what OpenAI does)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/2605 **Author:** [@jmorganca](https://github.com/jmorganca) **Created:** 2/20/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `whitespace-detection` --- ### 📝 Commits (1) - [`aae31dc`](https://github.com/ollama/ollama/commit/aae31dc6edab0781a00c9fab45f8d27967935905) naive whitespace detection ### 📊 Changes **1 file changed** (+19 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `llm/dyn_ext_server.go` (+19 -0) </details> ### 📄 Description This stops hanging from infinite whitespace generation by detecting 100 consecutive whitespace tokens and cancelling Other ideas: - [ ] Repetition detection – detect the repetition of the same string over and over again - [ ] Only do this after detecting a full json object - [ ] Lower whitespace logit bias when using JSON mode (might affect outcome of the response) - [ ] Force user to specify `JSON` in the prompt (might be hard for folks to know this, this is what OpenAI does) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-05 04:58:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#73239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?