github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #10771] Possible bug at llama/llama.go #7076

New Issue
Closed
opened 2026-04-12 19:00:24 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-12 19:00:24 -05:00
Owner
Copy Link

Originally created by @DarkCaster on GitHub (May 19, 2025).
Original GitHub issue: https://github.com/ollama/ollama/issues/10771

What is the issue?

Sorry for the possibly stupid question, I was studying the code and came across this (see image).

Why is the PenaltyPresent parameter from SamplingParams not used by C.struct_common_sampler_cparam, but instead PenaltyFreq is used twice in a row? Looks like a typo for me.

Image

Relevant log output

OS

No response

GPU

No response

CPU

No response

Ollama version

No response

Originally created by @DarkCaster on GitHub (May 19, 2025). Original GitHub issue: https://github.com/ollama/ollama/issues/10771 ### What is the issue? Sorry for the possibly stupid question, I was studying the code and came across this (see image). Why is the `PenaltyPresent` parameter from `SamplingParams` not used by `C.struct_common_sampler_cparam`, but instead `PenaltyFreq` is used twice in a row? Looks like a typo for me. ![Image](https://github.com/user-attachments/assets/4910e9c1-972d-4ec7-b866-d6bb4f21216d) ### Relevant log output ```shell ``` ### OS _No response_ ### GPU _No response_ ### CPU _No response_ ### Ollama version _No response_
GiteaMirror added the bug label 2026-04-12 19:00:24 -05:00
GiteaMirror commented 2026-04-12 19:00:26 -05:00
Author
Owner
Copy Link

@woojh3690 commented on GitHub (May 20, 2025):

Maybe related this issue.

https://github.com/ollama/ollama/issues/10767#issue-3072240517

<!-- gh-comment-id:2893578336 --> @woojh3690 commented on GitHub (May 20, 2025): Maybe related this issue. https://github.com/ollama/ollama/issues/10767#issue-3072240517
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#7076
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?