github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 00:51:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #12963] Data Race Conditions in Scheduler Tests #70653

New Issue
Open
opened 2026-05-04 22:23:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-04 22:23:27 -05:00
Owner
Copy Link

Originally created by @vincentkoc on GitHub (Nov 5, 2025).
Original GitHub issue: https://github.com/ollama/ollama/issues/12963

Originally assigned to: @dhiltgen on GitHub.

What is the issue?

The scheduler tests in server/sched_test.go contain data race conditions that cause intermittent test failures, particularly on Windows CI runners.

How to Reproduce

Method 1: Using Race Detector (Reliable)

go test -race -count=1 ./server

Method 2: Multiple Runs (Exposes Flakiness)

go test -race -count=5 ./server

Method 3: Specific Test Cases

go test -race ./server -run "TestSchedRequestsSimpleReloadSameModel|TestSchedRequestsMultipleLoadedModels"

Expected Behavior

Tests should pass consistently without data race warnings.

Actual Behavior

Tests fail with data race warnings:

WARNING: DATA RACE
Write at 0x00c00047dda0 by goroutine 18:
  github.com/ollama/ollama/server.TestSchedRequestsSimpleReloadSameModel()
      /path/to/ollama/server/sched_test.go:254 +0x864
  github.com/ollama/ollama/server.newScenarioRequest()
      /path/to/ollama/server/sched_test.go:119 +0x90c

Previous read at 0x00c00047dda0 by goroutine [...]

WARNING: DATA RACE
Read at 0x00c000614670 by goroutine 43:
  github.com/ollama/ollama/server.(*Scheduler).processPending()
      /path/to/ollama/server/sched.go:177 +0x404
  github.com/ollama/ollama/server.(*Scheduler).Run.func1()
      /path/to/ollama/server/sched.go:122 +0x40

Relevant log output

OS

Windows

GPU

No response

CPU

No response

Ollama version

No response

Originally created by @vincentkoc on GitHub (Nov 5, 2025). Original GitHub issue: https://github.com/ollama/ollama/issues/12963 Originally assigned to: @dhiltgen on GitHub. ### What is the issue? The scheduler tests in `server/sched_test.go` contain data race conditions that cause intermittent test failures, particularly on Windows CI runners. ## How to Reproduce ### Method 1: Using Race Detector (Reliable) ```bash go test -race -count=1 ./server ``` ### Method 2: Multiple Runs (Exposes Flakiness) ```bash go test -race -count=5 ./server ``` ### Method 3: Specific Test Cases ```bash go test -race ./server -run "TestSchedRequestsSimpleReloadSameModel|TestSchedRequestsMultipleLoadedModels" ``` ## Expected Behavior Tests should pass consistently without data race warnings. ## Actual Behavior Tests fail with data race warnings: ``` WARNING: DATA RACE Write at 0x00c00047dda0 by goroutine 18: github.com/ollama/ollama/server.TestSchedRequestsSimpleReloadSameModel() /path/to/ollama/server/sched_test.go:254 +0x864 github.com/ollama/ollama/server.newScenarioRequest() /path/to/ollama/server/sched_test.go:119 +0x90c Previous read at 0x00c00047dda0 by goroutine [...] WARNING: DATA RACE Read at 0x00c000614670 by goroutine 43: github.com/ollama/ollama/server.(*Scheduler).processPending() /path/to/ollama/server/sched.go:177 +0x404 github.com/ollama/ollama/server.(*Scheduler).Run.func1() /path/to/ollama/server/sched.go:122 +0x40 ``` ### Relevant log output ```shell ``` ### OS Windows ### GPU _No response_ ### CPU _No response_ ### Ollama version _No response_
GiteaMirror added the bug label 2026-05-04 22:23:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#70653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?