github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-09 01:59:50 -05:00
Code Issues 14.7k Packages Projects Releases 122 Wiki Activity

[GH-ISSUE #6078] Refactor num_parallel tracking in scheduler #65836

New Issue
Open
opened 2026-05-03 22:51:15 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-05-03 22:51:15 -05:00
Owner
Copy Link

Originally created by @dhiltgen on GitHub (Jul 30, 2024).
Original GitHub issue: https://github.com/ollama/ollama/issues/6078

Originally assigned to: @dhiltgen on GitHub.

What is the issue?

The current code passes a pointer and mutates it as we try to determine what the optimal parallel setting is, which makes the code hard to follow.

OS

No response

GPU

No response

CPU

No response

Ollama version

No response

Originally created by @dhiltgen on GitHub (Jul 30, 2024). Original GitHub issue: https://github.com/ollama/ollama/issues/6078 Originally assigned to: @dhiltgen on GitHub. ### What is the issue? The current code passes a pointer and mutates it as we try to determine what the optimal parallel setting is, which makes the code hard to follow. ### OS _No response_ ### GPU _No response_ ### CPU _No response_ ### Ollama version _No response_
GiteaMirror added the bug label 2026-05-03 22:51:15 -05:00
GiteaMirror commented 2026-05-03 22:51:18 -05:00
Author
Owner
Copy Link

@Icelain commented on GitHub (Aug 3, 2024):

Possibly a more readable approach would be to instead pass in numparallel to pickBestFullFitByLibrary and pickBestPartialFitByLibrary and have them return it back.

For example:
g, numParallel := pickBestFullFitByLibrary(pending, ggml, gpus, numParallel)
,
gpus, numParallel = pickBestPartialFitByLibrary(pending, ggml, gpus, numParallel)

<!-- gh-comment-id:2266685778 --> @Icelain commented on GitHub (Aug 3, 2024): Possibly a more readable approach would be to instead pass in numparallel to `pickBestFullFitByLibrary` and `pickBestPartialFitByLibrary` and have them return it back. For example: ```g, numParallel := pickBestFullFitByLibrary(pending, ggml, gpus, numParallel)``` , ```gpus, numParallel = pickBestPartialFitByLibrary(pending, ggml, gpus, numParallel)```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#65836
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?