github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 00:51:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15826] server: preserve generate logprobs with builtin parsers #62016

New Issue
Open
opened 2026-04-29 16:58:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:58:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15826
Author: @dhiltgen
Created: 4/26/2026
Status: 🔄 Open

Base: main ← Head: logprobs

📝 Commits (1)

  • 496b024 server: preserve generate logprobs with builtin parsers

📊 Changes

2 files changed (+117 additions, -2 deletions)

View changed files

📝 server/routes.go (+4 -2)
📝 server/routes_generate_test.go (+113 -0)

📄 Description

Generate requests were dropping logprob-only chunks whenever a builtin parser buffered visible content. Chat already handled this case, but generate only forwarded chunks with visible response, thinking, or tool-call output.

Keep generate chunks that carry logprobs even when the builtin parser has not flushed visible content yet, and add a regression test that exercises the behavior with a generic thinking parser.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15826 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 4/26/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `logprobs` --- ### 📝 Commits (1) - [`496b024`](https://github.com/ollama/ollama/commit/496b024486175e726258836fa9f205c6e6be3cf5) server: preserve generate logprobs with builtin parsers ### 📊 Changes **2 files changed** (+117 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+4 -2) 📝 `server/routes_generate_test.go` (+113 -0) </details> ### 📄 Description Generate requests were dropping logprob-only chunks whenever a builtin parser buffered visible content. Chat already handled this case, but generate only forwarded chunks with visible response, thinking, or tool-call output. Keep generate chunks that carry logprobs even when the builtin parser has not flushed visible content yet, and add a regression test that exercises the behavior with a generic thinking parser. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:58:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#62016
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?