github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15809] create: prune imported blobs and startup invalid leftovers #62012

New Issue
Open
opened 2026-04-29 16:58:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:58:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15809
Author: @stationeros
Created: 4/25/2026
Status: 🔄 Open

Base: main ← Head: main

📝 Commits (1)

  • e8de8d9 create: prune imported blobs and startup invalid leftovers

📊 Changes

4 files changed (+131 additions, -12 deletions)

View changed files

📝 server/create.go (+36 -0)
📝 server/images.go (+11 -12)
📝 server/images_test.go (+22 -0)
📝 server/routes_create_test.go (+62 -0)

📄 Description

Solves #15803

  • Fixes the main regression from the issue body: successful safetensors imports no longer leave their uploaded source blobs behind.
  • Restores restart-time cleanup for broken temporary blob files by pruning invalid blob names before applying the recent-blob grace period.
  • Keeps the current race-avoidance behavior for valid recent blobs, so it should not undo the newer create-vs-gc protection.
  • Stays tightly scoped to create/prune behavior with focused tests.

What changed

  1. In server/create.go, defer cleanup of request Files and Adapters blobs after create completes.
    • Uses manifest.RemoveLayers(), so blobs that are referenced by any manifest are preserved.
    • This safely handles reused GGUF inputs while removing converted/replaced imports.
  2. In server/images.go, validate blob names before applying the one-hour grace period.
    • Invalid blob files like *-partial or interrupted temp uploads are removed immediately during startup prune.
    • Valid digest-named blobs still keep the grace period.
  3. Added tests for:
    • safetensors create cleanup of imported source blobs
    • immediate pruning of recent invalid blob files

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15809 **Author:** [@stationeros](https://github.com/stationeros) **Created:** 4/25/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`e8de8d9`](https://github.com/ollama/ollama/commit/e8de8d9e290ec24eeed17492f5640d5a68405ce2) create: prune imported blobs and startup invalid leftovers ### 📊 Changes **4 files changed** (+131 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `server/create.go` (+36 -0) 📝 `server/images.go` (+11 -12) 📝 `server/images_test.go` (+22 -0) 📝 `server/routes_create_test.go` (+62 -0) </details> ### 📄 Description Solves #15803 - Fixes the main regression from the issue body: successful safetensors imports no longer leave their uploaded source blobs behind. - Restores restart-time cleanup for broken temporary blob files by pruning invalid blob names before applying the recent-blob grace period. - Keeps the current race-avoidance behavior for valid recent blobs, so it should not undo the newer create-vs-gc protection. - Stays tightly scoped to create/prune behavior with focused tests. What changed 1. In server/create.go, defer cleanup of request Files and Adapters blobs after create completes. - Uses manifest.RemoveLayers(), so blobs that are referenced by any manifest are preserved. - This safely handles reused GGUF inputs while removing converted/replaced imports. 2. In server/images.go, validate blob names before applying the one-hour grace period. - Invalid blob files like *-partial or interrupted temp uploads are removed immediately during startup prune. - Valid digest-named blobs still keep the grace period. 3. Added tests for: - safetensors create cleanup of imported source blobs - immediate pruning of recent invalid blob files --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:58:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#62012
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?