github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15787] [MERGED] api: accept "max" as a think value #62005

New Issue
Closed
opened 2026-04-29 16:57:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:57:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15787
Author: @ParthSareen
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @ParthSareen

Base: main ← Head: parth-add-max-to-valid-think

📝 Commits (3)

  • b868ccc api: accept "max" as a think value
  • 9ec4efe server: map think "max" to "high" for harmony models
  • 2389edd openai: accept "max" as a reasoning_effort value

📊 Changes

6 files changed (+87 additions, -15 deletions)

View changed files

📝 api/types.go (+7 -7)
📝 api/types_test.go (+5 -0)
📝 cmd/cmd.go (+2 -2)
📝 openai/openai.go (+2 -2)
📝 openai/openai_test.go (+51 -0)
📝 server/routes.go (+20 -4)

📄 Description

Some models will only accept max as a thinking value. Quick PR to support it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15787 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth-add-max-to-valid-think` --- ### 📝 Commits (3) - [`b868ccc`](https://github.com/ollama/ollama/commit/b868ccca5f9e7006fc5f52dead07d02951c58634) api: accept "max" as a think value - [`9ec4efe`](https://github.com/ollama/ollama/commit/9ec4efedbcc3a0f6aeb50e99acc046a3a8117e7d) server: map think "max" to "high" for harmony models - [`2389edd`](https://github.com/ollama/ollama/commit/2389eddc504acdbc4be2e95a607eb20018991c3d) openai: accept "max" as a reasoning_effort value ### 📊 Changes **6 files changed** (+87 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+7 -7) 📝 `api/types_test.go` (+5 -0) 📝 `cmd/cmd.go` (+2 -2) 📝 `openai/openai.go` (+2 -2) 📝 `openai/openai_test.go` (+51 -0) 📝 `server/routes.go` (+20 -4) </details> ### 📄 Description Some models will only accept `max` as a thinking value. Quick PR to support it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:57:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#62005
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?