github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15424] [MERGED] fix: improve error message for unknown input item type in responses API #61849

New Issue
Closed
opened 2026-04-29 16:51:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:51:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15424
Author: @sjhddh
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/9/2026
Merged by: @drifkin

Base: main ← Head: fix/responses-input-item-error

📝 Commits (1)

  • 6be6708 fix: improve error message for unknown input item type in responses API

📊 Changes

2 files changed (+27 additions, -1 deletions)

View changed files

📝 openai/responses.go (+4 -1)
📝 openai/responses_test.go (+23 -0)

📄 Description

Bug

unmarshalResponsesInputItem had two problems in its default error branch:

Wrong variable: The error used typeField.Type instead of itemType. These differ when the shorthand role-based format (e.g. {"role": "user", "content": "..."}) is used — in that case itemType is promoted to "message" while typeField.Type remains "". So if an unhandled type value somehow passed through, the error could show a stale/wrong string.

Unhelpful message on empty type: When both type and role are absent, itemType stays "". The old %s format produced:

unknown input item type:

That trailing space with nothing after it gives no useful signal.

Fix

default:
    if itemType == "" {
        return nil, fmt.Errorf("input item missing required 'type' field")
    }
    return nil, fmt.Errorf("unknown input item type: %q", itemType)
  • Uses itemType (the resolved value after shorthand promotion) instead of typeField.Type
  • Uses %q so the unknown value is always quoted and visible
  • Special-cases the empty string with a descriptive message

Tests

Added two test cases to TestUnmarshalResponsesInputItem:

  • missing type field — {"content": "hello"} (no type key at all)
  • empty type field — {"type": ""} (explicit empty string)

Both verify the error message is "input item missing required 'type' field".

Also tightened the existing unknown item type test to assert the exact quoted error string.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15424 **Author:** [@sjhddh](https://github.com/sjhddh) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@drifkin](https://github.com/drifkin) **Base:** `main` ← **Head:** `fix/responses-input-item-error` --- ### 📝 Commits (1) - [`6be6708`](https://github.com/ollama/ollama/commit/6be6708fa18801d96a08557808bf287933f8683a) fix: improve error message for unknown input item type in responses API ### 📊 Changes **2 files changed** (+27 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `openai/responses.go` (+4 -1) 📝 `openai/responses_test.go` (+23 -0) </details> ### 📄 Description ## Bug `unmarshalResponsesInputItem` had two problems in its `default` error branch: **Wrong variable**: The error used `typeField.Type` instead of `itemType`. These differ when the shorthand role-based format (e.g. `{"role": "user", "content": "..."}`) is used — in that case `itemType` is promoted to `"message"` while `typeField.Type` remains `""`. So if an unhandled type value somehow passed through, the error could show a stale/wrong string. **Unhelpful message on empty type**: When both `type` and `role` are absent, `itemType` stays `""`. The old `%s` format produced: ``` unknown input item type: ``` That trailing space with nothing after it gives no useful signal. ## Fix ```go default: if itemType == "" { return nil, fmt.Errorf("input item missing required 'type' field") } return nil, fmt.Errorf("unknown input item type: %q", itemType) ``` - Uses `itemType` (the resolved value after shorthand promotion) instead of `typeField.Type` - Uses `%q` so the unknown value is always quoted and visible - Special-cases the empty string with a descriptive message ## Tests Added two test cases to `TestUnmarshalResponsesInputItem`: - `missing type field` — `{"content": "hello"}` (no type key at all) - `empty type field` — `{"type": ""}` (explicit empty string) Both verify the error message is `"input item missing required 'type' field"`. Also tightened the existing `unknown item type` test to assert the exact quoted error string. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:51:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61849
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?