github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15196] Fix: Resolve incorrect GGUF magic validation in fs/gguf/gguf.go #61765

New Issue
Open
opened 2026-04-29 16:47:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:47:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15196
Author: @hieuit095
Created: 4/1/2026
Status: 🔄 Open

Base: main ← Head: fix/gguf-magic-validation

📝 Commits (1)

  • 8472594 Fix: Correct GGUF magic validation to use uppercase and proper logic

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 fs/gguf/gguf.go (+1 -1)

📄 Description

Summary

The GGUF magic validation in fs/gguf/gguf.go had two issues:

  1. Wrong case: The check compared against lowercase gguf but the actual GGUF magic is uppercase GGUF (ASCII: 0x47 0x47 0x55 0x46)
  2. Inverted logic: The check returned an error when magic equaled gguf, but it should return an error when magic does NOT equal the valid GGUF magic

Fix

Changed the condition to properly validate the GGUF magic:

  • Before: if bytes.Equal(f.Magic[:], []byte("gguf"))
  • After: if !bytes.Equal(f.Magic[:], []byte("GGUF"))

This ensures valid GGUF files are accepted and invalid/non-GGUF files are properly rejected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15196 **Author:** [@hieuit095](https://github.com/hieuit095) **Created:** 4/1/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/gguf-magic-validation` --- ### 📝 Commits (1) - [`8472594`](https://github.com/ollama/ollama/commit/84725946d7935020c64491f9d4edc92d82514fba) Fix: Correct GGUF magic validation to use uppercase and proper logic ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fs/gguf/gguf.go` (+1 -1) </details> ### 📄 Description ## Summary The GGUF magic validation in `fs/gguf/gguf.go` had two issues: 1. **Wrong case**: The check compared against lowercase `gguf` but the actual GGUF magic is uppercase `GGUF` (ASCII: 0x47 0x47 0x55 0x46) 2. **Inverted logic**: The check returned an error when magic equaled `gguf`, but it should return an error when magic does NOT equal the valid `GGUF` magic ## Fix Changed the condition to properly validate the GGUF magic: - Before: `if bytes.Equal(f.Magic[:], []byte("gguf"))` - After: `if !bytes.Equal(f.Magic[:], []byte("GGUF"))` This ensures valid GGUF files are accepted and invalid/non-GGUF files are properly rejected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:47:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61765
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?